Skip to content

Conversation

@arthuredelstein
Copy link

@arthuredelstein arthuredelstein commented Jul 24, 2016

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2016
* Set the machine type for this instance.
*
* @resource [Instances: setMachineType API Documentation]{@link https://cloud.google.com/compute/docs/reference/v1/instances/setMachineType}
*

This comment was marked as spam.

@coveralls
Copy link

coveralls commented Jul 24, 2016

Coverage Status

Coverage decreased (-0.07%) to 99.929% when pulling 74d2a74 on arthuredelstein:setMachineType into 9cdcef5 on GoogleCloudPlatform:master.

@arthuredelstein
Copy link
Author

Looks like I need to write unit tests. I will work on that (hopefully) later this week.

@stephenplusplus stephenplusplus added enhancement api: compute Issues related to the Compute Engine API. labels Jul 24, 2016
@stephenplusplus
Copy link
Contributor

Thanks @arthuredelstein!

@stephenplusplus
Copy link
Contributor

@arthuredelstein we just merged a PR that modularized the repo, which will allow us to release modules for each service, instead of having them all in one gcloud package. That brought some significant structure changes, but updating your PR shouldn't be too bad. The file you edited, lib/compute/vm.js, is now packages/compute/src/vm.js. Just move your code into that file, and you'll find the test file you need here: packages/compute/test/vm.js.

@stephenplusplus
Copy link
Contributor

I didn't want to make you do all that, so check it out: #1469. Let me know if it works as you intended!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: compute Issues related to the Compute Engine API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants