Support setting an origin when using resumable upload

[stephenplusplus]

Related:

• Authorization: Bearer your_auth_token (how to get auth_token) #818 (comment)
• Allow setting an origin gcs-resumable-upload#6

This will include a breaking change.

// Before
file.createResumableUpload(metadata, callback);

// After
var options = {
  metadata: {},
  origin: '*'
};

file.createResumableUpload(options, callback);

[stephenplusplus]

@gotmikhail - pulling you over here so you can track this.

I released gcs-resumable-upload@0.4.0 with support for an origin option: googleapis/gcs-resumable-upload@8f96167. So, that's available to use immediately until it makes it into gcloud-node.

[gotmikhail]

Here's what I've implemented:

var uploadConfig = {
    origin: '*',
    metadata: metadata,
    file: targetFile,
    bucket: targetBucket,
    authConfig: {
        keyFilename: cloudStorage.keyfile
    }
};
gcloudUpload.createURI(uploadConfig, function (err, uri) {
...
});

No errors on the server side, successfully generating a URI, but, still getting No 'Access-Control-Allow-Origin' header on the client. Any thoughts on what I'm doing wrong?

I went with the wildcard * to make sure things were working before refining it down to the client's origin.

[stephenplusplus]

@janesconference I'm sorry to bother you again. If you get a minute, do you have any insight on @gotmikhail's issue?

[gotmikhail]

@janesconference @stephenplusplus
I couldn't get the wildcard to work, but I did hard-code the origin and got that through w/ no xhr issues. I'm still having an issue with writing out the file successfully, getting a 200 back from the PUT request, the file is listed in Cloud Storage, Content-Type is correct, but unable to properly load the file. That may be fully on our side.

[cristiano-belloni]

@gotmikhail

I never tried with the wildcard, but sure it's working for me with the correct origin.

For this to work on the client, though, you have to set CORS in your target bucket appropriately.

You'll then be able to PUT your chunks on that address as multiple of 256k, get a 308 for each of them, then PUT the final one with a Content-Range end value, and get a 200. The process is described here and it's quite tricky.