Skip to content

console.warn in Impersonated constructor spams warnings #499

@sfc-gh-rsavenok

Description

@sfc-gh-rsavenok

Please make sure you have searched for information in the following guides.

A screenshot that you have tested with "Try this API".

N/A

Link to the code that reproduces this issue. A link to a public Github Repository or gist with a minimal reproduction.

https://github.com/googleapis/google-auth-library-nodejs/blob/a46981534014a5e6e042d14f0777b62bf559894a/src/auth/impersonated.ts#L124-L126

A step-by-step description of how to reproduce the issue, based on the linked reproduction.

Create a new instance of the Impersonated class

A clear and concise description of what the bug is, and what you expected to happen.

A recent change added a warning when using Impersonated class - googleapis/google-auth-library-nodejs@a469815

While this is a super useful warning, it creates unnecessary log messages for use cases without security risks.

WDYT about adding a new option to disable it?

A clear and concise description WHY you expect this behavior, i.e., was it a recent change, there is documentation that points to this behavior, etc. **

N/A

Metadata

Metadata

Assignees

No one assigned

    Labels

    size: sPull request size is small.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions