fix: replacing abc.com with example.com #1291
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abc.com is a domain owned by someone else and is not an example domain
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
nicain
approved these changes
May 11, 2023
Contributor
|
Can you make this change for the other occurrences of A cursory look: ❮ rg "abc.com"
samples/cloud-client/snippets/idtoken_from_metadata_server.py
31: Examples: http://www.abc.com
samples/cloud-client/snippets/idtoken_from_service_account.py
38: Examples: http://www.abc.com
tests/compute_engine/test_credentials.py
505: creds_with_token_uri = self.credentials.with_token_uri("http://abc.com")
506: assert creds_with_token_uri._token_uri == "http://abc.com" |
Contributor
|
Also, please update your commit to follow the conventional commit style. Thanks! |
arithmetic1728
changed the title
Contributor
|
fixed in #1316 @ToddKopriva thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abc.com is a domain owned by someone else and is not an example domain