Skip to content

createWithTokenEndpointResponseException always sets retry count to default #1584

@zhumin8

Description

@zhumin8

This might be a missed followup item after #988
Not sure about the context, seems related to issue with a version of HttpClient.

// TODO: temporarily setting retry Count to service account default to remove a direct
// dependency, to be reverted after release
return new GoogleAuthException(true, OAuth2Utils.DEFAULT_NUMBER_OF_RETRIES, ioException);
} else {
return new GoogleAuthException(
true, OAuth2Utils.DEFAULT_NUMBER_OF_RETRIES, message, ioException);
}

Code before this change:

https://github.com/googleapis/google-auth-library-java/blame/e1db9a86e81a24d35f6d2b36f16c5aff5b70305a/oauth2_http/java/com/google/auth/oauth2/GoogleAuthException.java#L119-L129

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p3Desirable enhancement or fix. May not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions