Skip to content
This repository was archived by the owner on Jul 13, 2025. It is now read-only.

python: fix channel options #2905

Merged
noahdietz merged 1 commit into from
Aug 2, 2019
Merged

python: fix channel options #2905

noahdietz merged 1 commit into from
Aug 2, 2019

Conversation

@noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Aug 2, 2019

Fix #2904

@noahdietz noahdietz requested review from busunkim96 and tseaver August 2, 2019 19:14
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 2, 2019
@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #2905 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2905   +/-   ##
=========================================
  Coverage     87.24%   87.24%           
  Complexity     5824     5824           
=========================================
  Files           476      476           
  Lines         23045    23045           
  Branches       2493     2493           
=========================================
  Hits          20106    20106           
  Misses         2101     2101           
  Partials        838      838

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f27258...771575e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 2, 2019 •
edited
Loading

Codecov Report

Merging #2905 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2905   +/-   ##
=========================================
  Coverage     87.24%   87.24%           
  Complexity     5824     5824           
=========================================
  Files           476      476           
  Lines         23045    23045           
  Branches       2493     2493           
=========================================
  Hits          20106    20106           
  Misses         2101     2101           
  Partials        838      838

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f27258...771575e. Read the comment docs.

@noahdietz noahdietz merged commit a0c166d into googleapis:master Aug 2, 2019
@noahdietz noahdietz deleted the fix-python-options branch August 2, 2019 19:53
@noahdietz noahdietz mentioned this pull request Aug 2, 2019
Merged
busunkim96 pushed a commit to busunkim96/gapic-generator that referenced this pull request Nov 7, 2019
@noahdietz @busunkim96
python: fix channel options (googleapis#2905)
b339222
@tswast tswast mentioned this pull request Oct 19, 2020
Closed
@busunkim96 busunkim96 mentioned this pull request Dec 10, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@tseaver tseaver tseaver approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Python: PR #2900 breaks system tests

4 participants

@noahdietz @tseaver @busunkim96 @googlebot