Skip to content

Conversation

@vchudnov-g
Copy link
Contributor

No description provided.

@vchudnov-g vchudnov-g requested review from a team as code owners June 10, 2021 23:03
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 10, 2021
@snippet-bot
Copy link

snippet-bot bot commented Jun 10, 2021

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #918 (ab3defd) into master (7c185e8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #918   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        27    +1     
  Lines         1608      1703   +95     
  Branches       328       347   +19     
=========================================
+ Hits          1608      1703   +95     
Impacted Files Coverage Δ
gapic/samplegen_utils/types.py 100.00% <ø> (ø)
gapic/samplegen_utils/utils.py 100.00% <ø> (ø)
gapic/utils/case.py 100.00% <ø> (ø)
gapic/utils/reserved_names.py 100.00% <ø> (ø)
gapic/generator/generator.py 100.00% <100.00%> (ø)
gapic/samplegen/samplegen.py 100.00% <100.00%> (ø)
gapic/schema/api.py 100.00% <100.00%> (ø)
gapic/schema/metadata.py 100.00% <100.00%> (ø)
gapic/schema/wrappers.py 100.00% <100.00%> (ø)
gapic/utils/__init__.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da119c7...ab3defd. Read the comment docs.

Copy link
Contributor

@software-dov software-dov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just delete the circleci configs instead of keeping them updated.

I'm very confused about the errors as well.

@arithmetic1728
Copy link
Contributor

I think we can just delete the circleci configs instead of keeping them updated.

I'm very confused about the errors as well.

Yes, that works for me.

@vchudnov-g vchudnov-g changed the title chore: Update Showcase to the latest released version, 0.15.0 chore: Update Showcase to the latest released version, 0.16.0 Jun 16, 2021
@vchudnov-g
Copy link
Contributor Author

@software-dov @busunkim96 Do these sound like spurious failures? All checks passed before merging master....

@vchudnov-g
Copy link
Contributor Author

So it looks like we're failing because the generated Showcase GAPIC has 0% code coverage, I guess because it doesn't have unit tests (?). I'm confused why this wasn't a problem before this PR.

Suggestions?

@software-dov
Copy link
Contributor

Took a look at the failing CI, and I believe that the code cov failure is possibly a red herring. The tests definitely run locally, definitely run in CI, but the coverage isn't being tracked correctly.

@software-dov
Copy link
Contributor

The update made it's way in via another PR. @vchudnov-g mind if we close this?

@vchudnov-g
Copy link
Contributor Author

Yes. let's close this, since this was done in #925

@vchudnov-g vchudnov-g closed this Jun 25, 2021
@tseaver tseaver deleted the vchudnov-showcase branch October 13, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants