Skip to content

fix: fix datetime comparison unit tests #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcf-merge-on-green merged 2 commits into from
May 20, 2021
Merged

fix: fix datetime comparison unit tests #898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef9a4b9
fix: fix datetime comparison unit tests
busunkim96 May 19, 2021
579af0a
Merge branch 'master' into fix-datetime-comparisons
gcf-merge-on-green[bot] May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gapic/ads-templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,9 +444,9 @@ def test_{{ method.name|snake_case }}_flattened():
assert len(call.mock_calls) == 1
_, args, _ = call.mock_calls[0]
{% for key, field in method.flattened_fields.items() %}{% if not field.oneof or field.proto3_optional %}
{% if field.ident|string() == 'timestamp.Timestamp' %}
{% if field.ident|string() == 'timestamp_pb2.Timestamp' %}
assert TimestampRule().to_proto(args[0].{{ key }}) == {{ field.mock_value }}
{% elif field.ident|string() == 'duration.Duration' %}
{% elif field.ident|string() == 'duration_pb2.Duration' %}
assert DurationRule().to_proto(args[0].{{ key }}) == {{ field.mock_value }}
{% else %}
assert args[0].{{ key }} == {{ field.mock_value }}
Expand Down
12 changes: 6 additions & 6 deletions gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,9 +760,9 @@ def test_{{ method.name|snake_case }}_flattened():
assert len(call.mock_calls) == 1
_, args, _ = call.mock_calls[0]
{% for key, field in method.flattened_fields.items() %}{% if not field.oneof or field.proto3_optional %}
{% if field.ident|string() == 'timestamp.Timestamp' %}
{% if field.ident|string() == 'timestamp_pb2.Timestamp' %}
assert TimestampRule().to_proto(args[0].{{ key }}) == {{ field.mock_value }}
{% elif field.ident|string() == 'duration.Duration' %}
{% elif field.ident|string() == 'duration_pb2.Duration' %}
assert DurationRule().to_proto(args[0].{{ key }}) == {{ field.mock_value }}
{% else %}
assert args[0].{{ key }} == {{ field.mock_value }}
Expand Down Expand Up @@ -845,9 +845,9 @@ async def test_{{ method.name|snake_case }}_flattened_async():
assert len(call.mock_calls)
_, args, _ = call.mock_calls[0]
{% for key, field in method.flattened_fields.items() %}{% if not field.oneof or field.proto3_optional %}
{% if field.ident|string() == 'timestamp.Timestamp' %}
{% if field.ident|string() == 'timestamp_pb2.Timestamp' %}
assert TimestampRule().to_proto(args[0].{{ key }}) == {{ field.mock_value }}
{% elif field.ident|string() == 'duration.Duration' %}
{% elif field.ident|string() == 'duration_pb2.Duration' %}
assert DurationRule().to_proto(args[0].{{ key }}) == {{ field.mock_value }}
{% else %}
assert args[0].{{ key }} == {{ field.mock_value }}
Expand Down Expand Up @@ -1194,9 +1194,9 @@ def test_{{ method.name|snake_case }}_rest_flattened():
body = http_params.get('data')
{% for key, field in method.flattened_fields.items() %}
{% if not field.oneof or field.proto3_optional %}
{% if field.ident|string() == 'timestamp.Timestamp' %}
{% if field.ident|string() == 'timestamp_pb2.Timestamp' %}
assert TimestampRule().to_proto(http_call[0].{{ key }}) == {{ field.mock_value }}
{% elif field.ident|string() == 'duration.Duration' %}
{% elif field.ident|string() == 'duration_pb2.Duration' %}
assert DurationRule().to_proto(http_call[0].{{ key }}) == {{ field.mock_value }}
{% else %}
assert {% if field.field_pb is msg_field_pb %}{{ field.ident }}.to_json({{ field.name }}, including_default_value_fields=False, use_integers_for_enums=False)
Expand Down