Skip to content

feat: Raise GoogleAPICallError on REST response errors #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vchudnov-g merged 4 commits into from
May 19, 2021
Merged

feat: Raise GoogleAPICallError on REST response errors #891

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f61e890
feat: Add rest.py:ResponseError to echo error response body
vchudnov-g May 18, 2021
e2e6083
On HTTP error, raise google.api_core.exceptions.GoogleAPICallError
vchudnov-g May 19, 2021
58786a8
Remove now-unused import
vchudnov-g May 19, 2021
296d8e0
Merge branch 'master' into vchudnov-informative-error
vchudnov-g May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ from typing import Callable, Dict, Optional, Sequence, Tuple
from google.api_core import operations_v1
{% endif %}
from google.api_core import gapic_v1 # type: ignore
from google.auth import credentials as ga_credentials # type: ignore
from google.auth.transport.grpc import SslCredentials # type: ignore
from google.api_core import exceptions as core_exceptions # type: ignore
from google.auth import credentials as ga_credentials # type: ignore
from google.auth.transport.grpc import SslCredentials # type: ignore

import grpc # type: ignore

Expand Down Expand Up @@ -214,8 +215,10 @@ class {{ service.name }}RestTransport({{ service.name }}Transport):
{% endif %}
)

# Raise requests.exceptions.HTTPError if the status code is >= 400
response.raise_for_status()
# In case of error, raise the appropriate core_exceptions.GoogleAPICallError exception
# subclass.
if response.status_code >= 400:
raise core_exceptions.from_http_response(response)
{% if not method.void %}

# Return the response
Expand Down