fix: fix rest transport unit test template #741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 1619 1619
Branches 328 328
=========================================
Hits 1619 1619 Continue to review full report at Codecov.
|
busunkim96
approved these changes
Jan 21, 2021
Contributor
busunkim96
left a comment
busunkim96
left a comment
There was a problem hiding this comment.
Are the generated unit tests for the REST transport not getting run in CI?
Contributor
Author
Looking at the testing log, it seems CI only generates and runs grpc unit tests. Filed an issue for this: #744 |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 21, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [0.40.2](https://www.github.com/googleapis/gapic-generator-python/compare/v0.40.1...v0.40.2) (2021-01-21) ### Bug Fixes * fix rest transport unit test template ([#741](https://www.github.com/googleapis/gapic-generator-python/issues/741)) ([54b9806](https://www.github.com/googleapis/gapic-generator-python/commit/54b98060f881c8f0424c7e146488d3adc19fec7a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up fix of #730
When regenerating python-compute, I noticed some unit test failure due to missing status code in the mock response. This PR adds status code to the mock response in the template.