Skip to content

fix: fix types on server and bidi streaming callables #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
software-dov merged 2 commits into from
Oct 8, 2020
Merged

fix: fix types on server and bidi streaming callables #641

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
355f21a
fix: Fix types on server and bidi streaming callables
dpcollins-google Oct 8, 2020
e27b9a3
fix: Fix imports
dpcollins-google Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gapic/templates/%namespace/%name_%version/%sub/services/%service/async_client.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from collections import OrderedDict
import functools
import re
from typing import Dict, {% if service.any_server_streaming %}AsyncIterable, {% endif %}{% if service.any_client_streaming %}AsyncIterator, {% endif %}Sequence, Tuple, Type, Union
from typing import Dict, {% if service.any_server_streaming %}AsyncIterable, Awaitable, {% endif %}{% if service.any_client_streaming %}AsyncIterator, {% endif %}Sequence, Tuple, Type, Union
import pkg_resources

import google.api_core.client_options as ClientOptions # type: ignore
Expand Down Expand Up @@ -117,7 +117,7 @@ class {{ service.async_client_name }}:
{%- if not method.server_streaming %}
) -> {{ method.client_output_async.ident }}:
{%- else %}
) -> AsyncIterable[{{ method.client_output_async.ident }}]:
) -> Awaitable[AsyncIterable[{{ method.client_output_async.ident }}]]:
{%- endif %}
r"""{{ method.meta.doc|rst(width=72, indent=8) }}

Expand Down