feat: support mtls env variables #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1519 1519
Branches 309 309
=========================================
Hits 1519 1519 Continue to review full report at Codecov.
|
Contributor
Author
|
@software-dov @busunkim96 Please take a look at this PR when you have time. Since it has a breaking change, it is nice to have client libs not yet converted to pick up this change as early as possible. Thanks! |
software-dov
reviewed
Sep 9, 2020
Contributor
software-dov
left a comment
software-dov
left a comment
There was a problem hiding this comment.
Looks good. There are a few things I want to discuss before approving.
gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/client.py.j2
Show resolved
Hide resolved
gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/client.py.j2
Outdated
Show resolved
Hide resolved
gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/client.py.j2
Outdated
Show resolved
Hide resolved
gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/client.py.j2
Show resolved
Hide resolved
gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/client.py.j2
Show resolved
Hide resolved
gapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2
Show resolved
Hide resolved
busunkim96
reviewed
Sep 9, 2020
gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc.py.j2
Show resolved
Hide resolved
gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/client.py.j2
Show resolved
Hide resolved
busunkim96
approved these changes
Sep 10, 2020
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the two mtls env variables mentioned in https://google.aip.dev/auth/4114
New behavior summary:
(1) GOOGLE_API_USE_CLIENT_CERTIFICATE env variable:
Values:
"true": use client cert if exists
"false" (default): never use client cert, even if it exists or it is explicitly provided by user
(2) GOOGLE_API_USE_MTLS_ENDPOINT env variable:
Values:
"never": use regular endpoint
"always": use mtls endpoint
"auto" (default): auto switch to mtls endpoint, if client cert exists and we are allowed to use it (controlled by GOOGLE_API_USE_CLIENT_CERTIFICATE)