Skip to content

Revert "fix: convert datetime back to proto for unit tests" #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
busunkim96 wants to merge 1 commit into from
Closed

Revert "fix: convert datetime back to proto for unit tests" #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions gapic/ads-templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ from unittest import mock
import grpc
import math
import pytest
from proto.marshal.rules.dates import DurationRule, TimestampRule

{# Import the service itself as well as every proto module that it imports. -#}
{% filter sort_lines -%}
Expand Down Expand Up @@ -376,13 +375,7 @@ def test_{{ method.name|snake_case }}_flattened():
assert len(call.mock_calls) == 1
_, args, _ = call.mock_calls[0]
{% for key, field in method.flattened_fields.items() -%}{%- if not field.oneof or field.proto3_optional %}
{% if field.ident|string() == 'timestamp.Timestamp' -%}
assert TimestampRule().to_proto(args[0].{{ key }}) == {{ field.mock_value }}
{% elif field.ident|string() == 'duration.Duration' -%}
assert DurationRule().to_proto(args[0].{{ key }}) == {{ field.mock_value }}
{% else -%}
assert args[0].{{ key }} == {{ field.mock_value }}
{% endif %}
{% endif %}{% endfor %}
{%- for oneofs in method.flattened_oneof_fields().values() %}
{%- with field = oneofs[-1] %}
Expand Down
13 changes: 0 additions & 13 deletions gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import grpc
from grpc.experimental import aio
import math
import pytest
from proto.marshal.rules.dates import DurationRule, TimestampRule

{# Import the service itself as well as every proto module that it imports. -#}
{% filter sort_lines -%}
Expand Down Expand Up @@ -575,13 +574,7 @@ def test_{{ method.name|snake_case }}_flattened():
assert len(call.mock_calls) == 1
_, args, _ = call.mock_calls[0]
{% for key, field in method.flattened_fields.items() -%}{%- if not field.oneof or field.proto3_optional %}
{% if field.ident|string() == 'timestamp.Timestamp' -%}
assert TimestampRule().to_proto(args[0].{{ key }}) == {{ field.mock_value }}
{% elif field.ident|string() == 'duration.Duration' -%}
assert DurationRule().to_proto(args[0].{{ key }}) == {{ field.mock_value }}
{% else -%}
assert args[0].{{ key }} == {{ field.mock_value }}
{% endif %}
{% endif %}{% endfor %}
{%- for oneofs in method.flattened_oneof_fields().values() %}
{%- with field = oneofs[-1] %}
Expand Down Expand Up @@ -660,13 +653,7 @@ async def test_{{ method.name|snake_case }}_flattened_async():
assert len(call.mock_calls)
_, args, _ = call.mock_calls[0]
{% for key, field in method.flattened_fields.items() -%}{%- if not field.oneof or field.proto3_optional %}
{% if field.ident|string() == 'timestamp.Timestamp' -%}
assert TimestampRule().to_proto(args[0].{{ key }}) == {{ field.mock_value }}
{% elif field.ident|string() == 'duration.Duration' -%}
assert DurationRule().to_proto(args[0].{{ key }}) == {{ field.mock_value }}
{% else -%}
assert args[0].{{ key }} == {{ field.mock_value }}
{% endif %}
{% endif %}{% endfor %}
{%- for oneofs in method.flattened_oneof_fields().values() %}
{%- with field = oneofs[-1] %}
Expand Down