Skip to content

fix: only require dataclases if python<3.7 #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
busunkim96 merged 9 commits into from
Jun 23, 2020
Merged

fix: only require dataclases if python<3.7 #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cdfbbc6
chore: explicitly require 3.7+
busunkim96 Jun 19, 2020
1f2a467
chore(deps): update dependency google-api-core to v1.21.0 (#473)
renovate-bot Jun 19, 2020
ef330f0
fix: keep 3.6, but tweak requirements.txt
busunkim96 Jun 19, 2020
0efc9b3
fix: restore missing extras_require
busunkim96 Jun 19, 2020
73a076c
Update requirements.txt
busunkim96 Jun 22, 2020
f574f04
Merge branch 'master' into require-3.7
busunkim96 Jun 22, 2020
e69b927
fix: add pin to install_requires too
busunkim96 Jun 22, 2020
07c6167
fix: try always using 0.6
busunkim96 Jun 22, 2020
bd190f4
fix: make dataclasses import conditional
busunkim96 Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ MarkupSafe==1.1.1
protobuf==3.12.2
pypandoc==1.5
PyYAML==5.3.1
dataclasses==0.7
dataclasses==0.6; python_version < '3.7'
Copy link
Contributor

@vam-google vam-google Jun 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming this syntax is understood by bazel python rules properly (the python_version < '3.7' part). Note, requirements.txt is currently used only by bazel.

Copy link
Contributor

@alexander-fenster alexander-fenster Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently it does not :( (or something else is wrong)

3 changes: 3 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,11 @@
"protobuf >= 3.12.0",
"pypandoc >= 1.4",
"PyYAML >= 5.1.1",
"dataclasses < 0.7; python_version < '3.7'"
),
extras_require={':python_version<"3.7"': ("dataclasses >= 0.4",),},
tests_require=("pyfakefs >= 3.6",),
python_requires=">=3.6",
classifiers=(
"Development Status :: 4 - Beta",
"Environment :: Console",
Expand All @@ -62,6 +64,7 @@
"Operating System :: POSIX",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Topic :: Software Development :: Code Generators",
"Topic :: Software Development :: Libraries :: Python Modules",
),
Expand Down