Skip to content

Conversation

@noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Nov 3, 2025

Populates the api_version field on a per-service basis to the generated gapic_metadata.json using the value from the service-level annotation google.api.api_version already parsed for use in the X-Goog-Api-Version/$apiVersion system parameter (as of #1999).

One unit test for gapic_metadata generation is updated to include an api_version proto service extension for populating. The other omits it which subsequently tests the negative case. None of the APIs used for integration test goldens currently set the annotation, so those are not updated.

It's presence in gapic_metadata.json will allow parsers to correlate service client to API version. It is not in use by any API yet.

Internal bug http://b/452365074.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 3, 2025
@noahdietz noahdietz force-pushed the gapic-metadata-api-version branch from 0ecf83a to 1f0588d Compare November 10, 2025 22:26
@noahdietz noahdietz marked this pull request as ready for review November 10, 2025 22:33
@noahdietz noahdietz requested a review from a team as a code owner November 10, 2025 22:33
@parthea parthea enabled auto-merge (squash) November 11, 2025 15:50
@parthea parthea merged commit c424e33 into googleapis:main Nov 11, 2025
136 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants