-
Notifications
You must be signed in to change notification settings - Fork 76
Closed
Labels
🚨This issue needs some love.This issue needs some love.api: pubsubIssues related to the Pub/Sub API.Issues related to the Pub/Sub API.lang: pythonIssues specific to Python.Issues specific to Python.triage meI really want to be triaged.I really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
This was first reported in Python PubSub issue #303, and analysis was posted in a comment. See the issue for details on how to reproduce it.
Wrapped methods in PubSub transports use an incorrect deadline - it should be 60.0 seconds, but instead the API core's default timeout of 120.0 seconds is used. This can be fixed if the deadline keyword argument is explicitly passed into default Retry instances that wrap the transport methods.
I do see that default_timeout is passed into wrap_method(), but when the generated publisher client invokes the wrapped method, the computed timeout_ is None, and it's the default Retry object that dictates the total deadline.
Metadata
Metadata
Assignees
Labels
🚨This issue needs some love.This issue needs some love.api: pubsubIssues related to the Pub/Sub API.Issues related to the Pub/Sub API.lang: pythonIssues specific to Python.Issues specific to Python.triage meI really want to be triaged.I really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.