Skip to content

Incorrect timeout used when wrapping methods in pubsub_v1 transports #794

@plamut

Description

@plamut

This was first reported in Python PubSub issue #303, and analysis was posted in a comment. See the issue for details on how to reproduce it.

Wrapped methods in PubSub transports use an incorrect deadline - it should be 60.0 seconds, but instead the API core's default timeout of 120.0 seconds is used. This can be fixed if the deadline keyword argument is explicitly passed into default Retry instances that wrap the transport methods.

I do see that default_timeout is passed into wrap_method(), but when the generated publisher client invokes the wrapped method, the computed timeout_ is None, and it's the default Retry object that dictates the total deadline.

Metadata

Metadata

Assignees

No one assigned

    Labels

    🚨This issue needs some love.api: pubsubIssues related to the Pub/Sub API.lang: pythonIssues specific to Python.triage meI really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions