Skip to content

Duplicated Operations in Mutate Requests #756

@BenRKarl

Description

@BenRKarl

In the Ads templates, here, the below logic is generated for our operations parameter, an example from proto can be found here: MuateAdGroups and MutateAdGroupsRequest

if customer_id is not None:
    request.customer_id = customer_id
if operations is not None:
    request.operations = operations

if operations:
    request.operations.extend(operations)

If operations is present, request.operations is set, and request.operations.extend is also called, causing our operations to be duplicated in any request.

Metadata

Metadata

Assignees

No one assigned

    Labels

    lang: pythonIssues specific to Python.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.release blockingRequired feature/issue must be fixed prior to next release.simply blockertype: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions