fix: only require dataclases if python<3.7 #475
Conversation
googlebot
added
the
cla: yes
busunkim96
changed the title
| @@ -1,9 +1,9 @@ | |||
| click==7.1.2 | |||
| google-api-core==1.20.1 | |||
| google-api-core==1.21.0 | |||
There was a problem hiding this comment.
Not sure why this is showing up in the diff, but this is already 1.21.0 in master.
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1466 1466
Branches 300 300
=========================================
Hits 1466 1466 Continue to review full report at Codecov.
|
requirements.txt
Outdated
| pypandoc==1.5 | ||
| PyYAML==5.3.1 | ||
| dataclasses==0.7 | ||
| dataclasses==0.7; python_version < '3.7' |
There was a problem hiding this comment.
This should be 0.6 instead, otherwise it will fail bazel build.
vam-google
left a comment
vam-google
left a comment
There was a problem hiding this comment.
LGTM, but please verify that bazel rules work with this.
| pypandoc==1.5 | ||
| PyYAML==5.3.1 | ||
| dataclasses==0.7 | ||
| dataclasses==0.6; python_version < '3.7' |
There was a problem hiding this comment.
LGTM, assuming this syntax is understood by bazel python rules properly (the python_version < '3.7' part). Note, requirements.txt is currently used only by bazel.
There was a problem hiding this comment.
apparently it does not :( (or something else is wrong)
5 participants
The dataclasses package now only supports 3.6, which creates some weirdness with the requirements.txt requiring
0.7.0.