Skip to content

Conversation

@bcoe
Copy link

@bcoe bcoe commented May 6, 2019

temporary patch broken Windows container, such that tests can be run on Node 10

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 6, 2019
@codecov
Copy link

codecov bot commented May 6, 2019

Codecov Report

Merging #479 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #479   +/-   ##
=======================================
  Coverage   73.33%   73.33%           
=======================================
  Files           6        6           
  Lines         270      270           
  Branches       56       56           
=======================================
  Hits          198      198           
  Misses         57       57           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6ccf64...06163b7. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 6, 2019

Codecov Report

Merging #479 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #479   +/-   ##
=======================================
  Coverage   73.33%   73.33%           
=======================================
  Files           6        6           
  Lines         270      270           
  Branches       56       56           
=======================================
  Hits          198      198           
  Misses         57       57           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6ccf64...06163b7. Read the comment docs.

@nolanmar511 nolanmar511 requested a review from jkwlui May 6, 2019 19:07
@bcoe bcoe merged commit 96879a7 into master May 6, 2019
@bcoe bcoe deleted the node-10-windows branch May 6, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants