Skip to content

Conversation

@nolanmar511
Copy link
Contributor

Also ran npm run fix , and fixed indicated errors.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 29, 2019
@nolanmar511 nolanmar511 requested a review from ofrobots April 29, 2019 22:44
Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp.

@ofrobots
Copy link
Contributor

Did you have fix errors manually? Some users are reporting need to run gts twice to get all the errors autofixed.

I would be very curious of examples of indicated errors that were not autofixable.

@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #474 into master will increase coverage by 0.7%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #474     +/-   ##
=========================================
+ Coverage   72.62%   73.33%   +0.7%     
=========================================
  Files           6        6             
  Lines         263      270      +7     
  Branches       54       56      +2     
=========================================
+ Hits          191      198      +7     
  Misses         57       57             
  Partials       15       15
Impacted Files Coverage Δ
ts/src/config.ts 100% <ø> (ø) ⬆️
ts/src/logger.ts 53.84% <100%> (ø) ⬆️
ts/src/index.ts 56.98% <84.61%> (+0.94%) ⬆️
ts/src/profiler.ts 85% <87.5%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7857afa...13b4cdc. Read the comment docs.

@nolanmar511
Copy link
Contributor Author

I did run gts twice, but I don't know that it was because gts needed to be run twice. The first time, it pointed out .deepEqual() was deprecated, and the second time it pointed out .equal() was deprecated. (I had to manually change each of those -- which seems reasonable).

It seems likely that I just didn't scroll up enough to see where it logged that .equal() was deprecated.

@nolanmar511 nolanmar511 merged commit da5769c into googleapis:master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants