Skip to content

Conversation

@nolanmar511
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2019
@aalexand
Copy link
Contributor

@nolanmar511 The npmaudit test still fails? Also, elaborate on "temporarily"? Is there an issue tracking the fix / enabling it back?

@nolanmar511
Copy link
Contributor Author

NPM audit failure is blocking the release of the Node.JS agent.

I will re-enable this as soon as I get the Node.JS agent released

@nolanmar511 nolanmar511 requested a review from kalyanac March 29, 2019 00:17
@kalyanac
Copy link
Contributor

Is there an open issue against mocha to use js-yaml 3.13.0?
https://github.com/nodeca/js-yaml/releases/tag/3.13.0

@kalyanac kalyanac merged commit 5388c20 into googleapis:master Mar 29, 2019
@nolanmar511
Copy link
Contributor Author

mochajs/mocha#3842 is the issue for mocha to update js-yaml.

It's closed, since the change is submitted. I posted there today to ask when there next release will be.

@nolanmar511 nolanmar511 deleted the rm-npmaudit branch March 29, 2019 03:00
@nolanmar511
Copy link
Contributor Author

This did not work. I got:

npm ERR! publish Failed PUT 404
npm ERR! code E404
npm ERR! 404 Not found : @google-cloud/profiler
npm ERR! 404 
npm ERR! 404  '@google-cloud/profiler' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

This is the same error I had with the Kokoro release workflow. I think that this may indicate the npm token we had been using is now invalid, and we'll need to use the per-repo npm token in keystore.

I can either update our Kokoro release workflow, or transition to using https://github.com/googleapis/releasetool (use by https://github.com/googleapis/cloud-debug-nodejs).

I will take a look tomorrow.

nolanmar511 added a commit that referenced this pull request Mar 29, 2019
@kalyanac kalyanac changed the title fix: temporarily don't npmaudit check to pass before release fix: temporarily don't require npmaudit check to pass before release Mar 29, 2019
nolanmar511 added a commit that referenced this pull request Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants