Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

Conversation

@garrettjonesgoogle
Copy link
Member

This isn't for review exactly, it's more to look at for amusement.

@bjwatson
Copy link
Contributor

bjwatson commented Apr 7, 2017

@garrettjonesgoogle How did you create this? Is everything in google-cloud-compute-v1/src/main/java/com/google/cloud/compute/spi/v1 hand-written using an existing GAPIC template, and then everything else generated with protoc from the proto2 files?

@garrettjonesgoogle
Copy link
Member Author

@bjwatson I hand-converted the proto 2 file for InstancesService to proto 3 (and put that in compute_instances.proto), hand-converted the service yaml, used the gapic config generator to create the gapic yaml, then generated the client.

@bjwatson
Copy link
Contributor

bjwatson commented Apr 7, 2017

Ok, that makes sense.

@lukesneeringer lukesneeringer added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 14, 2017
@lukesneeringer lukesneeringer changed the title (DO NOT MERGE) Java: generating nonfunctional compute client Java: generating nonfunctional compute client Apr 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants