IsAvailable: Fix "type mismatch" and print nicer errors #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarnett
force-pushed
the
isavailable_error
branch
from
8094b28 to
ec60f46
Compare
Prints user-friendly errors if a formatter fails an IsAvailable call (also allowing other formatters to still be checked), and fixes a particular "type mismatch" error encountered on vim versions older than 7.4.1546. Fixes #155.
dbarnett
force-pushed
the
isavailable_error
branch
from
ec60f46 to
b363080
Compare
|
LGTM |
|
Postfacto LGTM =) |
dbarnett
commented
Sep 8, 2020
| \ !empty(get(b:, 'codefmt_formatter')) | ||
| if !empty(get(b:, 'codefmt_formatter')) | ||
| return 1 | ||
| endfor |
There was a problem hiding this comment.
Wut. I somehow used :endfor instead of :endif here without seeing any test failures. Gotta fix that and check what's up with test coverage…
There was a problem hiding this comment.
Oh, because the tests usually disable it with #SetWhetherToPerformIsAvailableChecksForTesting(). 🤦
Stay tuned for fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prints user-friendly errors if a formatter fails an IsAvailable call (also allowing other formatters to still be checked), and fixes a particular "type mismatch" error encountered on vim versions older than
7.4.1546.
Fixes #155.