-
Notifications
You must be signed in to change notification settings - Fork 189
Switch to pub workspace #1001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pub workspace #1001
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
We should also mention in the changelogs for protobuf and protoc_plugin that the new min. sdk is 3.6.
Good point, do you know if this should be a major or minor version bump? Technically it could break protobuf users and require them to bump Dart minor version, but bumping Dart minor version won't break any code. So I'm not sure if we consider this PR as breaking? |
I think we generally don't consider it breaking, but more something to note in the changelog. They'll still be able to solve in the previous publish, if they're doing something like running on a 3.5 SDK. You can probably just append to the current changelog entry (which is ready to publish). WDYT about publishing after this and the deprecation annotation PR land? I'll have more changes this week, some of which will require minor version bumps (new API). |
Ah, I thought we already published the major versions as we don't have the
SGTM. |
]; | ||
|
||
... | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block is indented so that it'll be a part of the bulleted list.
Revisions updated by `dart tools/rev_sdk_deps.dart`. protobuf (https://github.com/dart-lang/protobuf/compare/b7753f6..deda288): deda288 2025-05-19 Devon Carew address a merge issue with the protoc_plugin changelog (google/protobuf.dart#1002) 5ed4611 2025-05-19 Devon Carew shorten the deprecation messages for clone() and copyWith() (google/protobuf.dart#999) 4960b92 2025-05-19 Ömer Sinan Ağacan Switch to pub workspace (google/protobuf.dart#1001) test (https://github.com/dart-lang/test/compare/b9c59ea..5ffcb36): 5ffcb36f 2025-05-19 Danny Tuppeny Fix an issue with failed assertions using setUpAll/tearDownAll (dart-lang/test#2499) Change-Id: Idc43e2f2fd9dc38b80917b25b45bb954076dc1c9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/429480 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Devon Carew <[email protected]>
No description provided.