Skip to content

Commit 40323df

Browse files
devoncarewCommit Queue
authored and
Commit Queue
committed
[deps] rev protobuf, test
Revisions updated by `dart tools/rev_sdk_deps.dart`. protobuf (https://github.com/dart-lang/protobuf/compare/b7753f6..deda288): deda288 2025-05-19 Devon Carew address a merge issue with the protoc_plugin changelog (google/protobuf.dart#1002) 5ed4611 2025-05-19 Devon Carew shorten the deprecation messages for clone() and copyWith() (google/protobuf.dart#999) 4960b92 2025-05-19 Ömer Sinan Ağacan Switch to pub workspace (google/protobuf.dart#1001) test (https://github.com/dart-lang/test/compare/b9c59ea..5ffcb36): 5ffcb36f 2025-05-19 Danny Tuppeny Fix an issue with failed assertions using setUpAll/tearDownAll (dart-lang/test#2499) Change-Id: Idc43e2f2fd9dc38b80917b25b45bb954076dc1c9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/429480 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Devon Carew <[email protected]>
1 parent b3beefb commit 40323df

File tree

3 files changed

+28
-22
lines changed

3 files changed

+28
-22
lines changed

DEPS

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,12 +139,12 @@ vars = {
139139
"leak_tracker_rev": "f5620600a5ce1c44f65ddaa02001e200b096e14c", # rolled manually
140140
"material_color_utilities_rev": "799b6ba2f3f1c28c67cc7e0b4f18e0c7d7f3c03e",
141141
"native_rev": "2d4b07ae9a11ede9d434dbef5cded0ad08e22e3f", # rolled manually while native assets are experimental
142-
"protobuf_rev": "b7753f6fc29402679e05e9a510074002f0826d48",
142+
"protobuf_rev": "deda2883eb3c8437a89bdae524b732fffef6150c",
143143
"pub_rev": "59406faad8959e332da98260bab894feb8500908", # rolled manually
144144
"shelf_rev": "082d3ac2d13a98700d8148e8fad8f3e12a6fd0e1",
145145
"sync_http_rev": "dc54465f07d9652875deeade643256dafa2fbc6c",
146146
"tar_rev": "5a1ea943e70cdf3fa5e1102cdbb9418bd9b4b81a",
147-
"test_rev": "b9c59ea01ab0c055d120fd6542af663704c16938",
147+
"test_rev": "5ffcb36fd6c82843f25ed96585a4b9e96022e7f9",
148148
"tools_rev": "36f5c9f9989e06e79323499914c50e78ab1a6621",
149149
"vector_math_rev": "13f185f7e97d559e003f5ac79201da12f9a01049",
150150
"web_rev": "f1becf07db9faa56559d2844c3c6d430dc9b37de",

pkg/vm_service_protos/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ resolution: workspace
1313

1414
dependencies:
1515
fixnum: ^1.0.0
16-
protobuf: ">=4.0.0 <5.0.0"
16+
protobuf: ^4.0.0
1717

1818
# We use 'any' version constraints here as we get our package versions from
1919
# the dart-lang/sdk repo's DEPS file. Note that this is a special case; the

tools/package_deps/bin/package_deps.dart

Lines changed: 25 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -193,13 +193,6 @@ class Package implements Comparable<Package> {
193193
var devdeps = devDependencies;
194194
devdeps.remove(packageName);
195195

196-
// if (deps.isNotEmpty) {
197-
// print(' deps : ${deps}');
198-
// }
199-
// if (devdeps.isNotEmpty) {
200-
// print(' dev deps: ${devdeps}');
201-
// }
202-
203196
void out(String message) {
204197
logger.stdout(logger.ansi.emphasized(message));
205198
}
@@ -467,23 +460,36 @@ class SdkDeps {
467460

468461
void _findPackages(Directory dir) {
469462
var pubspec = File(path.join(dir.path, 'pubspec.yaml'));
463+
470464
if (pubspec.existsSync()) {
471465
var doc = yaml.loadYamlDocument(pubspec.readAsStringSync());
466+
if (doc.contents is! yaml.YamlMap) {
467+
// Stop recursing.
468+
return;
469+
}
470+
472471
var contents = doc.contents as yaml.YamlMap;
473-
var name = contents['name'];
474-
var version = contents['version'];
475-
var dep = ResolvedDep(
476-
packageName: name,
477-
relativePath: path.relative(dir.path),
478-
version: version == null ? null : Version.parse(version),
479-
);
480-
_resolvedPackageVersions[name] = dep;
481-
} else {
482-
// Continue to recurse.
483-
for (var subDir in dir.listSync().whereType<Directory>()) {
484-
_findPackages(subDir);
472+
final isWorkspace = contents.containsKey('workspace');
473+
474+
if (!isWorkspace) {
475+
var name = contents['name'];
476+
var version = contents['version'];
477+
var dep = ResolvedDep(
478+
packageName: name,
479+
relativePath: path.relative(dir.path),
480+
version: version == null ? null : Version.parse(version),
481+
);
482+
_resolvedPackageVersions[name] = dep;
483+
484+
// We've found a leaf package - stop recursing.
485+
return;
485486
}
486487
}
488+
489+
// Continue to recurse.
490+
for (var subDir in dir.listSync().whereType<Directory>()) {
491+
_findPackages(subDir);
492+
}
487493
}
488494
}
489495

0 commit comments

Comments
 (0)