Make TestHttpsInsecure test reliably passing on Darwin. #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestHttpsInsecure test runs a profiling session and checks that the results contain expected function name. On OSX prior to 10.11 El Capitan the SIGPROF signal is delivered to the process rather than to the thread which skews the results enough for the test to fail. Relax the check when running on OSX and other operating systems known to have issues with the profiling signal (the list is taken from src/runtime/pprof/pprof_test.go in Go source). Also add the multiple variants of OSX to the continuous testing. Fixes google#146 and google#156.
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
=======================================
Coverage 53.45% 53.45%
=======================================
Files 32 32
Lines 6181 6181
=======================================
Hits 3304 3304
Misses 2521 2521
Partials 356 356Continue to review full report at Codecov.
|
rauls5382
reviewed
Jul 22, 2017
| deadline := time.Now().Add(5 * time.Second) | ||
| for time.Now().Before(deadline) { | ||
| // Simulate a hotspot function. | ||
| for i := 0; i < 1e8; i++ { |
Contributor
There was a problem hiding this comment.
Why the empty loop? Doesn't the Go compiler remove it?
Collaborator
Author
There was a problem hiding this comment.
I have added a comment. The purpose is to ensure the samples mostly land onto the loop. As far as I can tell Go compiler doesn't elide empty loops now.
@aalexand0:tmp$ cat test.go
package main
func main() {
for i := 0; i < 16; i++ {
}
}
@aalexand0:tmp$ go build test.go
@aalexand0:tmp$ objdump -d test | grep -A10 "<main.main>:"
00000000004511c0 <main.main>:
4511c0: 31 c0 xor %eax,%eax
4511c2: eb 03 jmp 4511c7 <main.main+0x7>
4511c4: 48 ff c0 inc %rax
4511c7: 48 83 f8 10 cmp $0x10,%rax
4511cb: 7c f7 jl 4511c4 <main.main+0x4>
4511cd: c3 retq
4511ce: cc int3
4511cf: cc int3
00000000004511d0 <main.init>:
nolanmar511
approved these changes
Jul 24, 2017
gmarin13
pushed a commit
to gmarin13/pprof
that referenced
this pull request
Dec 17, 2020
* Make TestHttpsInsecure test reliably passing on Darwin. TestHttpsInsecure test runs a profiling session and checks that the results contain expected function name. On OSX prior to 10.11 El Capitan the SIGPROF signal is delivered to the process rather than to the thread which skews the results enough for the test to fail. Relax the check when running on OSX and other operating systems known to have issues with the profiling signal (the list is taken from src/runtime/pprof/pprof_test.go in Go source). Also add the multiple variants of OSX to the continuous testing. Fixes google#146 and google#156. * Document the motivation for the empty loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestHttpsInsecure test runs a profiling session and checks that the
results contain expected function name. On OSX prior to 10.11 El Capitan
the SIGPROF signal is delivered to the process rather than to the thread
which skews the results enough for the test to fail.
Relax the check when running on OSX and other operating systems known to
have issues with the profiling signal (the list is taken from
src/runtime/pprof/pprof_test.go in Go source).
Also add the multiple variants of OSX to the continuous testing.
Fixes #146 and fixes #156.