`includeToJson: false` is not working properly

[mernen]

Given the following class:

@JsonSerializable(createFactory: false, createToJson: true)
class SerializationTest {
  SerializationTest(this.x, this.y);

  final int x;
  @JsonKey(includeToJson: false)
  final int y;

  Map<String, dynamic> toJson() => _$SerializationTestToJson(this);
}

I would expect the generated serializer to only include x. However, this is the produced function:

Map<String, dynamic> _$SerializationTestToJson(SerializationTest instance) =>
    <String, dynamic>{
      'x': instance.x,
      'y': instance.y,
    };

Also serializing y.

y disappears if we change the annotation to includeFromJson: false.

I believe the culprit is this line:

json_serializable.dart/json_serializable/lib/src/generator_helper.dart

Line 154 in 832fc7b

bool get explicitNoToJson => includeFromJson == false;

It should test for includeToJson == false.

---

Environment:

dependencies:
  json_annotation: ^4.8.0

dev_dependencies:
  build_runner: ^2.3.3
  json_serializable: ^6.6.0

$ dart --version
Dart SDK version: 2.19.0-444.2.beta (beta) (Thu Dec 15 17:12:16 2022 +0000) on "macos_arm64"

[aytunch]

This is not an answer but in your pubspec.yaml, you put json_serializable under dev_dependencies instead of dependencies
However in the installation section it says json_serializable should be under dependencies
https://pub.dev/packages/json_serializable/install

Does it make any difference? What is the correct convention? Some clarification would be highly appreciated.
Thanks

[kevmoo]

Hey @aytunch – that's a bug on pub.dev. I'll create an issue!