Skip to content

[exec] Write trailing newline to -pid-file and -internal-pid-file #11861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[exec] Write trailing newline to -pid-file and -internal-pid-file #11861

wants to merge 1 commit into from

Conversation

stepancheg
Copy link
Contributor

@stepancheg stepancheg commented Jun 27, 2025 •
edited
Loading

When executing command, otherwise it is not possible to know when the pid file is fully written.

Resolves #11851

This PR only changes exec command, and not other commands that write pid files.

@stepancheg
[exec] Write trailing newline to -pid-file and -internal-pid-file
726d8d9 
Resolves google#11851

This PR only changes `exec` command, and not other commands that write
pid files.
copybara-service bot pushed a commit that referenced this pull request Jul 8, 2025
@stepancheg @gvisor-bot
[exec] Write trailing newline to -pid-file and -internal-pid-file
e73f4d1 
When executing command, otherwise it is not possible to know when the pid file is fully written.

Resolves #11851

This PR only changes `exec` command, and not other commands that write pid files.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11861 from stepancheg:pid-file 726d8d9
PiperOrigin-RevId: 780722929
@copybara-service copybara-service bot mentioned this pull request Jul 8, 2025
Closed
copybara-service bot pushed a commit that referenced this pull request Jul 8, 2025
@stepancheg @gvisor-bot
[exec] Write trailing newline to -pid-file and -internal-pid-file
44ba29f 
When executing command, otherwise it is not possible to know when the pid file is fully written.

Resolves #11851

This PR only changes `exec` command, and not other commands that write pid files.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11861 from stepancheg:pid-file 726d8d9
PiperOrigin-RevId: 780722929
copybara-service bot pushed a commit that referenced this pull request Jul 8, 2025
@stepancheg @gvisor-bot
[exec] Write trailing newline to -pid-file and -internal-pid-file
1720cba 
When executing command, otherwise it is not possible to know when the pid file is fully written.

Resolves #11851

This PR only changes `exec` command, and not other commands that write pid files.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11861 from stepancheg:pid-file 726d8d9
PiperOrigin-RevId: 780722929
copybara-service bot pushed a commit that referenced this pull request Jul 8, 2025
@stepancheg @gvisor-bot
[exec] Write trailing newline to -pid-file and -internal-pid-file
f153d69 
When executing command, otherwise it is not possible to know when the pid file is fully written.

Resolves #11851

This PR only changes `exec` command, and not other commands that write pid files.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11861 from stepancheg:pid-file 726d8d9
PiperOrigin-RevId: 780722929
copybara-service bot pushed a commit that referenced this pull request Jul 8, 2025
@stepancheg @gvisor-bot
[exec] Write trailing newline to -pid-file and -internal-pid-file
a967c06 
When executing command, otherwise it is not possible to know when the pid file is fully written.

Resolves #11851

This PR only changes `exec` command, and not other commands that write pid files.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11861 from stepancheg:pid-file 726d8d9
PiperOrigin-RevId: 780722929
copybara-service bot pushed a commit that referenced this pull request Jul 8, 2025
@stepancheg @gvisor-bot
[exec] Write trailing newline to -pid-file and -internal-pid-file
e41d4f5 
When executing command, otherwise it is not possible to know when the pid file is fully written.

Resolves #11851

This PR only changes `exec` command, and not other commands that write pid files.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11861 from stepancheg:pid-file 726d8d9
PiperOrigin-RevId: 780722929
copybara-service bot pushed a commit that referenced this pull request Jul 9, 2025
@stepancheg @gvisor-bot
[exec] Write trailing newline to -pid-file and -internal-pid-file
05bfeae 
When executing command, otherwise it is not possible to know when the pid file is fully written.

Resolves #11851

This PR only changes `exec` command, and not other commands that write pid files.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11861 from stepancheg:pid-file 726d8d9
PiperOrigin-RevId: 780722929
copybara-service bot pushed a commit that referenced this pull request Jul 9, 2025
@stepancheg @gvisor-bot
[exec] Write trailing newline to -pid-file and -internal-pid-file
2887811 
When executing command, otherwise it is not possible to know when the pid file is fully written.

Resolves #11851

This PR only changes `exec` command, and not other commands that write pid files.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11861 from stepancheg:pid-file 726d8d9
PiperOrigin-RevId: 780722929
copybara-service bot pushed a commit that referenced this pull request Jul 9, 2025
@stepancheg @gvisor-bot
[exec] Write trailing newline to -pid-file and -internal-pid-file
075195f 
When executing command, otherwise it is not possible to know when the pid file is fully written.

Resolves #11851

This PR only changes `exec` command, and not other commands that write pid files.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11861 from stepancheg:pid-file 726d8d9
PiperOrigin-RevId: 780722929
copybara-service bot pushed a commit that referenced this pull request Jul 10, 2025
@stepancheg @gvisor-bot
[exec] Write trailing newline to -pid-file and -internal-pid-file
8217909 
When executing command, otherwise it is not possible to know when the pid file is fully written.

Resolves #11851

This PR only changes `exec` command, and not other commands that write pid files.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11861 from stepancheg:pid-file 726d8d9
PiperOrigin-RevId: 780722929
copybara-service bot pushed a commit that referenced this pull request Jul 10, 2025
@stepancheg @gvisor-bot
[exec] Write trailing newline to -pid-file and -internal-pid-file
7934a11 
When executing command, otherwise it is not possible to know when the pid file is fully written.

Resolves #11851

This PR only changes `exec` command, and not other commands that write pid files.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11861 from stepancheg:pid-file 726d8d9
PiperOrigin-RevId: 780722929
@stepancheg
Copy link
Contributor Author

Closing for now; I'll create a new one with writing pid file using tmp file.

@stepancheg stepancheg closed this Jul 23, 2025
@stepancheg stepancheg mentioned this pull request Jul 30, 2025
Merged
copybara-service bot pushed a commit that referenced this pull request Aug 14, 2025
@stepancheg @gvisor-bot
Write pidfile atomically
e75406d 
Fixes #11851. Alternative to #11861.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11983 from stepancheg:pid-file-2 e31a03d
PiperOrigin-RevId: 794437043
@copybara-service copybara-service bot mentioned this pull request Aug 14, 2025
Merged
copybara-service bot pushed a commit that referenced this pull request Aug 14, 2025
@stepancheg @gvisor-bot
Write pidfile atomically
ccd34bb 
Fixes #11851. Alternative to #11861.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11983 from stepancheg:pid-file-2 e31a03d
PiperOrigin-RevId: 794437043
copybara-service bot pushed a commit that referenced this pull request Aug 14, 2025
@stepancheg @gvisor-bot
Write pidfile atomically
a9005d5 
Fixes #11851. Alternative to #11861.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11983 from stepancheg:pid-file-2 e31a03d
PiperOrigin-RevId: 794437043
copybara-service bot pushed a commit that referenced this pull request Aug 15, 2025
@stepancheg @gvisor-bot
Write pidfile atomically
a4386f9 
Fixes #11851. Alternative to #11861.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11983 from stepancheg:pid-file-2 e31a03d
PiperOrigin-RevId: 794437043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready to pull
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exec -internal-pid-file cannot be used reliably
2 participants
@stepancheg @avagin