Allow not handled packets for UDP Forwarder #11850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ayushr2
reviewed
Jun 25, 2025
OkamiW
force-pushed
the
udp-forwarder-not-handled-packets
branch
from
59c8c5a to
9912f38
Compare
By Netstack, do you mean https://github.com/google/netstack? This functionality is very useful for handling packets coming from a TUN interface. |
|
By netstack, I meant https://github.com/google/gvisor/tree/master/pkg/tcpip. The netstack repo you linked was internalized into the gVisor repo some time back. |
ayushr2
approved these changes
Jun 26, 2025
|
pls fix the cla/google check |
Done. |
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
For TCP forwarder, we can reset the connection with r.Complete(true). For UDP forwarder, there was no way to reset the connection. gVisor already sends ICMP port unreachable for unhandled packets, but udp.Forwarder.HandlePacket always returns true. So we change the handler's function signature to return a bool type value, indicating whether the packet was handled or not. Thus allowing us to send ICMP port unreachable for failed UDP connections. FUTURE_COPYBARA_INTEGRATE_REVIEW=#11850 from OkamiW:udp-forwarder-not-handled-packets 9912f38 PiperOrigin-RevId: 777960633
|
Gentle ping. |
manninglucas
reviewed
Jul 7, 2025
For TCP forwarder, we can reset the connection with r.Complete(true). For UDP forwarder, there was no way to reset the connection. gVisor already sends ICMP port unreachable for unhandled packets, but udp.Forwarder.HandlePacket always returns true. So we change the handler's function signature to return a bool type value, indicating whether the packet was handled or not. Thus allowing us to send ICMP port unreachable for failed UDP connections.
OkamiW
force-pushed
the
udp-forwarder-not-handled-packets
branch
from
9912f38 to
496c218
Compare
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 9, 2025
For TCP forwarder, we can reset the connection with r.Complete(true). For UDP forwarder, there was no way to reset the connection. gVisor already sends ICMP port unreachable for unhandled packets, but udp.Forwarder.HandlePacket always returns true. So we change the handler's function signature to return a bool type value, indicating whether the packet was handled or not. Thus allowing us to send ICMP port unreachable for failed UDP connections. FUTURE_COPYBARA_INTEGRATE_REVIEW=#11850 from OkamiW:udp-forwarder-not-handled-packets 496c218 PiperOrigin-RevId: 777960633
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 9, 2025
For TCP forwarder, we can reset the connection with r.Complete(true). For UDP forwarder, there was no way to reset the connection. gVisor already sends ICMP port unreachable for unhandled packets, but udp.Forwarder.HandlePacket always returns true. So we change the handler's function signature to return a bool type value, indicating whether the packet was handled or not. Thus allowing us to send ICMP port unreachable for failed UDP connections. FUTURE_COPYBARA_INTEGRATE_REVIEW=#11850 from OkamiW:udp-forwarder-not-handled-packets 496c218 PiperOrigin-RevId: 777960633
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 9, 2025
For TCP forwarder, we can reset the connection with r.Complete(true). For UDP forwarder, there was no way to reset the connection. gVisor already sends ICMP port unreachable for unhandled packets, but udp.Forwarder.HandlePacket always returns true. So we change the handler's function signature to return a bool type value, indicating whether the packet was handled or not. Thus allowing us to send ICMP port unreachable for failed UDP connections. FUTURE_COPYBARA_INTEGRATE_REVIEW=#11850 from OkamiW:udp-forwarder-not-handled-packets 496c218 PiperOrigin-RevId: 777960633
|
Gentle ping. |
manninglucas
approved these changes
Jul 14, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
For TCP forwarder, we can reset the connection with r.Complete(true). For UDP forwarder, there was no way to reset the connection. gVisor already sends ICMP port unreachable for unhandled packets, but udp.Forwarder.HandlePacket always returns true. So we change the handler's function signature to return a bool type value, indicating whether the packet was handled or not. Thus allowing us to send ICMP port unreachable for failed UDP connections. FUTURE_COPYBARA_INTEGRATE_REVIEW=#11850 from OkamiW:udp-forwarder-not-handled-packets 496c218 PiperOrigin-RevId: 783025458
This was referenced Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For TCP forwarder, we can reset the connection with r.Complete(true). For UDP forwarder, there was no way to reset the connection.
gVisor already sends ICMP port unreachable for unhandled packets, but udp.Forwarder.HandlePacket always returns true.
So we change the handler's function signature to return a bool type value, indicating whether the packet was handled or not. Thus allowing us to send ICMP port unreachable for failed UDP connections.