runsc: create file as destination for file mount #11719
Open
+219
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test/cl753398796
branch
8 times, most recently
from
7028af3 to
368c1dc
Compare
Linux does not allow mounting files on top of directories and vice versa. This can lead to unexpected behavior and issues, such as `dockerd` failing to start when it encounters a file mount that appears as a directory entry during `/dev` enumeration. After this change, new mount destinations (files or directories) are created with permissions (0644 for files, 0755 for directories) consistent with `runc` behavior. Previously, new directories were created with 0777. The test case that request a bind mount into /dev/fd has been removed. /dev/fd is a symlink to /proc/self/fd. PiperOrigin-RevId: 753398796
copybara-service
bot
force-pushed
the
test/cl753398796
branch
from
368c1dc to
c678c8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runsc: create file as destination for file mount
Linux does not allow mounting files on top of directories and vice versa.
This can lead to unexpected behavior and issues, such as
dockerdfailingto start when it encounters a file mount that appears as a directory entry
during
/devenumeration.After this change, new mount destinations (files or directories) are created
with permissions (0644 for files, 0755 for directories) consistent with
runcbehavior. Previously, new directories were created with 0777.
The test case that request a bind mount into /dev/fd has been removed.
/dev/fd is a symlink to /proc/self/fd.