Add retries for temporary network issues #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #471 +/- ##
==========================================
+ Coverage 62.37% 62.83% +0.46%
==========================================
Files 74 76 +2
Lines 3686 3721 +35
==========================================
+ Hits 2299 2338 +39
+ Misses 1078 1074 -4
Partials 309 309
Continue to review full report at Codecov.
|
jonjohnsonjr
force-pushed
the
retry-temporary-network
branch
3 times, most recently
from
51cadbf to
48fee3d
Compare
imjasonh
approved these changes
Jun 20, 2019
jonjohnsonjr
changed the title
jonjohnsonjr
force-pushed
the
retry-temporary-network
branch
5 times, most recently
from
eb20d78 to
8e750bc
Compare
jonjohnsonjr
changed the title
jonjohnsonjr
force-pushed
the
retry-temporary-network
branch
2 times, most recently
from
f706e93 to
281d486
Compare
We pretty commonly see this issue when communicating with a registry: ``` Get https://gcr.io/v2/: net/http: TLS handshake timeout ``` This causes a huge amount of pain if it's a failure within e.g. a large CI job, since the entire thing would fail. Fixes google#77
jonjohnsonjr
force-pushed
the
retry-temporary-network
branch
from
281d486 to
1333cbe
Compare
imjasonh
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pretty commonly see this issue when communicating with a registry:
This causes a huge amount of pain if it's a failure within e.g. a large
CI job, since the entire thing would fail.
Fixes #77
This uses
k8s.io/apimachinery/pkg/util/waitbecause we happen to already depend on it.