Skip to content

No public description #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

No public description #1589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions conformance/run.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,9 @@ class ConformanceTest : public testing::Test {
if (!test_.bindings().empty()) {
for (const auto& binding : test_.bindings()) {
absl::Cord serialized;
ABSL_CHECK(binding.second.SerializePartialToCord(&serialized));
ABSL_CHECK(binding.second.SerializePartialToString(&serialized));
ABSL_CHECK((*eval_request.mutable_bindings())[binding.first]
.ParsePartialFromCord(serialized));
.ParsePartialFromString(serialized));
}
}

Expand All @@ -145,9 +145,9 @@ class ConformanceTest : public testing::Test {
check_request.set_container(test_.container());
for (const auto& type_env : test_.type_env()) {
absl::Cord serialized;
ABSL_CHECK(type_env.SerializePartialToCord(&serialized));
ABSL_CHECK(type_env.SerializePartialToString(&serialized));
ABSL_CHECK(
check_request.add_type_env()->ParsePartialFromCord(serialized));
check_request.add_type_env()->ParsePartialFromString(serialized));
}
CheckResponse check_response;
service_->Check(check_request, check_response);
Expand Down Expand Up @@ -177,9 +177,10 @@ class ConformanceTest : public testing::Test {
switch (test_.result_matcher_case()) {
case SimpleTest::kValue: {
absl::Cord serialized;
ABSL_CHECK(eval_response.result().SerializePartialToCord(&serialized));
ABSL_CHECK(
eval_response.result().SerializePartialToString(&serialized));
cel::expr::ExprValue test_value;
ABSL_CHECK(test_value.ParsePartialFromCord(serialized));
ABSL_CHECK(test_value.ParsePartialFromString(serialized));
EXPECT_THAT(test_value,
cel_conformance::MatchesConformanceValue(test_.value()));
break;
Expand All @@ -188,9 +189,10 @@ class ConformanceTest : public testing::Test {
ASSERT_TRUE(eval_request.has_checked_expr())
<< "expression was not type checked";
absl::Cord serialized;
ABSL_CHECK(eval_response.result().SerializePartialToCord(&serialized));
ABSL_CHECK(
eval_response.result().SerializePartialToString(&serialized));
cel::expr::ExprValue test_value;
ABSL_CHECK(test_value.ParsePartialFromCord(serialized));
ABSL_CHECK(test_value.ParsePartialFromString(serialized));
EXPECT_THAT(test_value, cel_conformance::MatchesConformanceValue(
test_.typed_result().result()));
EXPECT_THAT(eval_request.checked_expr(),
Expand Down