Integrate OpenTelemetry (OTel) support: 2. use telemetry functions in the code

[mingjourney]

No description provided.

[kalenkevich]

This seems to be confusing to be me as here few things happens:

1. OTEL context is bidding to the generator function
2. with .call(this) you call generatorFuction with specified function context

2 context binding happening here for 2 different purposes and this is tricky to understand
I think we can improve that a bit, final function will look like a wrapper:

Suggested change

	yield* bindAsyncGenerator(ctx, (async function* (this: LlmAgent) {
	yield* runAsyncGeneratorWithOtelContext(otelCtx, this, async function* () {
	...
	});

then in tracing.ts

Suggested change

	yield* bindAsyncGenerator(ctx, (async function* (this: LlmAgent) {
	function bindOtelContextToAsyncGenerator<T = unknown, TReturn = any, TNext = unknown>(
	ctx: Context,
	generator: AsyncGenerator<T, TReturn, TNext>,
	): AsyncGenerator<T, TReturn, TNext> {
	return {
	next: context.bind(ctx, generator.next.bind(generator)),
	return: context.bind(ctx, generator.return.bind(generator)),
	throw: context.bind(ctx, generator.throw.bind(generator)),
	[Symbol.asyncIterator]() {
	return bindOtelContextToAsyncGenerator(ctx, generator[Symbol.asyncIterator]());
	},
	};
	}
	export function runAsyncGeneratorWithOtelContext<T = unknown, TReturn = any, TNext = unknown>(
	otelContext: Context,
	generatorFnContext: unknown,
	generatorFn: () => AsyncGenerator<T, TReturn, TNext>
	): AsyncGenerator<T, TReturn, TNext> {
	// call generator function with 'this' context available inside.
	const generator = generatorFn().call(generatorFnContext);
	return bindOtelContextToAsyncGenerator(otelContext, generator);
	}

[mingjourney]

that looks like a good improvement. I'll test it out.

[mingjourney]

sync this branch with main to clean up the diff

[mingjourney]

The changes are complete, and this has been successfully bound.

[kalenkevich]

Do we need this TThis type?

[mingjourney]

Do we need this TThis type?

Yes, TThis is necessary here. It ensures type safety for the this context inside the generator function.