Remove keychain name param #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fd0a5a8.
…e-GIDAuthStateMigrationFake
Member
|
Looks pretty good to me! This just needs to resolve the conflicts. |
…en-king/remove-keychain-name-param
…en-king/remove-keychain-name-param
camden-king
force-pushed
the
camden-king/create-GIDAuthStateMigrationFake
branch
from
5595d18 to
26a118a
Compare
Base automatically changed from
camden-king/create-GIDAuthStateMigrationFake
to
camden-king/migration-bug-fixes
June 18, 2025 19:47
brnnmrls
approved these changes
Jun 18, 2025
camden-king
merged commit 5b30eb9
into
camden-king/migration-bug-fixes
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the unused keychainName param from
migrateIfNeededWithTokenURL.