Add support for GTMAppAuth 5 on macOS #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

camden-king merged 15 commits into main from camden-king/GTMAppAuth-v5-mac-support

May 20, 2025

Contributor

camden-king commented May 13, 2025

This PR make the changes for GTMAppAuth v5 to work on iOS, specifically:

Added entitlements to days until birthday for macOS.
Updates documentation that $(AppIdentifierPrefix)$(CFBundleIdentifier) must be added as an access group for macOS apps.
Adds migration logic on macOS to migrate keys stored using GTMAppAuth < v5.

camden-king added 8 commits

May 9, 2025 11:12


          update entitlements for sample app + docuemntation

d330203


          add migration logic

90a9f4d


          add migration logic

7c44268


          add migration code

2d1e82f


          fix tests for GIDAuthStateMigration

634c7fe


          remove unnessisary changes

ec65658


          changes to get ready for review

9ac80e9


          update test imports

99b0405

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Sources/GIDAuthStateMigration.m Outdated Show resolved Hide resolved


          fix alignment

5daf3a4

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Sources/GIDAuthStateMigration.m Outdated Show resolved Hide resolved

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Sources/GIDAuthStateMigration.m Outdated Show resolved Hide resolved

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Sources/GIDSignIn.m Outdated Show resolved Hide resolved

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated Show resolved Hide resolved

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated Show resolved Hide resolved

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated Show resolved Hide resolved

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated Show resolved Hide resolved

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated Show resolved Hide resolved

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated Show resolved Hide resolved

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated Show resolved Hide resolved

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated Show resolved Hide resolved

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated Show resolved Hide resolved

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated Show resolved Hide resolved

brnnmrls reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

brnnmrls reviewed

View reviewed changes

README.md Show resolved Hide resolved

camden-king added 4 commits

May 14, 2025 15:50


          changes from review

0154b3b


          use seperate migration keys

7a7483c


          update tests

55b88cc


          updates from review

f4faadc

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Sources/GIDAuthStateMigration.m Show resolved Hide resolved

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Sources/GIDAuthStateMigration.m Outdated Show resolved Hide resolved

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Sources/GIDAuthStateMigration.m Show resolved Hide resolved

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated Show resolved Hide resolved

brnnmrls reviewed

View reviewed changes

Member

brnnmrls left a comment

A few nits to clean up, otherwise looks pretty good to me!

camden-king and others added 2 commits

May 20, 2025 13:45


          changes from review

4dbaaf9


          Merge branch 'main' into camden-king/GTMAppAuth-v5-mac-support

edd8aae

brnnmrls approved these changes

View reviewed changes

camden-king merged commit 9e8be62 into main

15 checks passed

camden-king deleted the camden-king/GTMAppAuth-v5-mac-support branch

May 20, 2025 22:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet