Fix Undefined symbols issue #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add AppAuthCore as explicit dependency to GoogleSignIn target.
|
Would love to see this merged, this low level SDK is used by so many other Google related SDKs, which makes it hard, or even impossible to fork and consume separately |
|
Any update on this? we are getting issues importing GSI in a project that uses it from different subprojects. I believe this could fix it. |
yalkhder
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AppAuthCore as explicit dependency to GoogleSignIn target as there are symbols that it uses from that library.
It is needed where GoogleSignIn is used as dynamic library/framework. This is the case when GoogleSignIn is added to multiple targets in dependency graph where 2 dynamic libraries/frameworks exist.
Example of it can be seen in project that @cjwirth provided in #408.
Fixes: #408