Do not modally animate the presenting of app check loading UI #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update CocoaPods sample project.
yalkhder
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the presentation of the loading UI when it takes more than 0.5 seconds to load the token. Previously, we would modally present a view controller with an activity indicator. That animation was awkward because it would pop the presenting view controller backwards, and overlay the loading UI. The updated presentation avoids that animation, and overlays a transparent gray view over the presenting view controller's view.
Before: https://github.com/google/GoogleSignIn-iOS/assets/4029922/ff8ede7b-118c-422b-94fa-0eb4c9a6b6b1
After: https://github.com/google/GoogleSignIn-iOS/assets/4029922/6eff3f98-09cb-4ade-84cc-1c30383dfa8c