Depend on AppCheckCore instead of FirebaseAppCheck #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove app attest provider used in sample app that is no longer needed.
ch40w31
requested changes
Aug 1, 2023
GoogleSignIn/Sources/GIDAppCheck/Implementations/Fake/GIDAppCheckProviderFake.m
Show resolved
Hide resolved
Standardize constant names to use kGID prefix; improve documentation; add an -init method to GIDAppCheck to allow callers use default values for NSUserDefaults and GACAppCheckProvider.
AppCheckCore main branch updated to have its own Package.swift; also update convenience initializer on GIDAppCheck to call thru to designated initializer.
ch40w31
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes GSI's dependency on Firebase and
FirebaseAppCheckin favor of the leanerAppCheckCore. The benefit of using this dependency is that neither GSI nor downstream clients will need depedencies on other Firebase targets or will have to be Firebase projects themselves.