Skip to content

Add a configuration property populated via Info.plist #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
petea merged 10 commits into from
Sep 29, 2022
Merged

Add a configuration property populated via Info.plist #228

petea merged 10 commits into from
Sep 29, 2022

Conversation

@petea
Copy link
Contributor

@petea petea commented Sep 23, 2022 •
edited
Loading

  • Provide a new configuration property on GIDSignIn representing the active config.
  • Update the API surface to remove the GIDConfiguration parameter from the signIn method signatures.
  • Create a mechanism to automatically set the configuration property via Info.plist.

@petea petea marked this pull request as ready for review September 26, 2022 23:33
Alex-4-Git
Alex-4-Git reviewed Sep 27, 2022
View reviewed changes
@petea petea changed the title Provide configuration via Info.plist Add a configuration property populated via Info.plist Sep 27, 2022
mdmathias
mdmathias reviewed Sep 28, 2022
View reviewed changes
mdmathias
mdmathias reviewed Sep 29, 2022
View reviewed changes
@petea petea merged commit ae5276c into main Sep 29, 2022
@petea petea deleted the petea-config branch September 29, 2022 20:38
@petea petea added this to the 7.0.0 milestone Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdmathias mdmathias mdmathias approved these changes

+1 more reviewer

@Alex-4-Git Alex-4-Git Alex-4-Git approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@petea @mdmathias @Alex-4-Git