Fix resource loading in GoogleSignInSwift with CocoaPods use_frameworks! #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Should we write a test for this? We're already running the unit tests through the |
mdmathias
force-pushed
the
mdmathias/fix-use-frameworks
branch
2 times, most recently
from
d20dbed to
aff19b5
Compare
petea
reviewed
Aug 12, 2022
Samples/Swift/DaysUntilBirthday/DaysUntilBirthdayForPod.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
GoogleSignInSwift/Tests/Unit/GoogleSignInButtonExtensionsTests.swift
Outdated
Show resolved
Hide resolved
GoogleSignInSwift/Tests/Unit/GoogleSignInButtonExtensionsTests.swift
Outdated
Show resolved
Hide resolved
mdmathias
force-pushed
the
mdmathias/fix-use-frameworks
branch
from
aff19b5 to
8b5e668
Compare
petea
approved these changes
Aug 12, 2022
mdmathias
force-pushed
the
mdmathias/fix-use-frameworks
branch
from
8b5e668 to
3256b3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a project using CocoaPods as its dependency manager added
use_frameworks!in itsPodfile, then we would fail to load resources from the bundle. This failure would lead to Google Sign-In image icon for the button to not load, for example.The reason for this failure was that we were previously using a class in the GoogleSignInSwift target to find the
Bundle. While we would be able to find thisBundle, it would not contain the resources included in theBundlefor GoogleSignIn.Fixes #194