Skip to content

Prevent build errors for GoogleSignInSwift when using SPM #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petea merged 2 commits into from
May 27, 2022
Merged

Prevent build errors for GoogleSignInSwift when using SPM #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0093398
Prevent missing symbol errors when building for armv7.
petea May 26, 2022
dbc4584
Merge branch 'main' into petea-arm
petea May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions GoogleSignInSwift/Sources/GoogleSignInButton.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
* limitations under the License.
*/

#if !arch(arm)

import SwiftUI
import CoreGraphics

Expand Down Expand Up @@ -191,3 +193,5 @@ private extension Font {
return CTFontManagerRegisterGraphicsFont(newFont, nil)
}
}

#endif // !arch(arm)
4 changes: 4 additions & 0 deletions GoogleSignInSwift/Sources/GoogleSignInButtonBundleExtensions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
* limitations under the License.
*/

#if !arch(arm)

import Foundation

// MARK: - Bundle Extensions
Expand Down Expand Up @@ -62,3 +64,5 @@ extension Bundle {
return bundle?.url(forResource: name, withExtension: ext)
}
}

#endif // !arch(arm)
4 changes: 4 additions & 0 deletions GoogleSignInSwift/Sources/GoogleSignInButtonStrings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
* limitations under the License.
*/

#if !arch(arm)

import Foundation

/// A type retrieving the localized strings for the sign-in button text.
Expand Down Expand Up @@ -56,3 +58,5 @@ struct GoogleSignInButtonString {
return localizedString(key: wideButtonText, text: "No translation")
}
}

#endif // !arch(arm)
4 changes: 4 additions & 0 deletions GoogleSignInSwift/Sources/GoogleSignInButtonStyling.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
* limitations under the License.
*/

#if !arch(arm)

import SwiftUI

// MARK: - Sizing Constants
Expand Down Expand Up @@ -280,3 +282,5 @@ struct SwiftUIButtonStyle: ButtonStyle {
)
}
}

#endif // !arch(arm)
4 changes: 4 additions & 0 deletions GoogleSignInSwift/Sources/GoogleSignInButtonViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
* limitations under the License.
*/

#if !arch(arm)

import Combine

/// A view model for the SwiftUI sign-in button publishing changes for the
Expand Down Expand Up @@ -47,3 +49,5 @@ public class GoogleSignInButtonViewModel: ObservableObject {
self.state = state
}
}

#endif // !arch(arm)