This repository was archived by the owner on Oct 7, 2024. It is now read-only.
add 'loading_message' flag to env loaders #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sometimes we have custom loggers and don't want to see this stuff, so here's a simple flag to turn off the logging when you create a bsuite env
bionicles
changed the title
|
@aslanides does this look OK? just wanted a way to turn off the loading messages as they were handled elsewhere in my current logging setup |
|
Hi @bionicles -- thanks for this, the changes look good. To accept this PR we need you to sign a CLA, but it seems the googlebot hasn't been triggered on this PR. Do you mind making a fresh PR with these changes, which I can then review and merge? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a boolean flag to turn off the loading message when a bsuite env is created (in case it interferes with other messages)