Renamed goodix5110 to goodixtls, Implemented linking against OpenSSL #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpi3d
pushed a commit
that referenced
this pull request
Dec 29, 2022
Update to newest libfprint version
sarovin
pushed a commit
to sarovin/libfprint
that referenced
this pull request
Mar 23, 2025
../libfprint/drivers/synaptics/bmkt_message.c:260:5: runtime error: null pointer passed as argument 2, which is declared to never be null
#0 0x7fd21f154592 in bmkt_compose_message ../libfprint/drivers/synaptics/bmkt_message.c:260
goodix-fp-linux-dev#1 0x7fd21f14596c in synaptics_sensor_cmd ../libfprint/drivers/synaptics/synaptics.c:417
goodix-fp-linux-dev#2 0x7fd21f14d93f in dev_probe ../libfprint/drivers/synaptics/synaptics.c:1329
goodix-fp-linux-dev#3 0x7fd21f0ca61d in device_idle_probe_cb ../libfprint/fp-device.c:375
goodix-fp-linux-dev#4 0x7fd21f21a431 in timeout_dispatch ../libfprint/fpi-device.c:336
goodix-fp-linux-dev#5 0x7fd2269cf70b in g_main_dispatch ../../glib/glib/gmain.c:3373
goodix-fp-linux-dev#6 0x7fd2269d18de in g_main_context_dispatch_unlocked ../../glib/glib/gmain.c:4224
goodix-fp-linux-dev#7 0x7fd2269d18de in g_main_context_iterate_unlocked ../../glib/glib/gmain.c:4289
goodix-fp-linux-dev#8 0x7fd2269d1fef in g_main_context_iteration ../../glib/glib/gmain.c:4354
goodix-fp-linux-dev#9 0x7fd21f0c5a85 in fp_context_enumerate ../libfprint/fp-context.c:575
sarovin
pushed a commit
to sarovin/libfprint
that referenced
this pull request
Mar 23, 2025
../libfprint/drivers/goodixmoc/goodix_proto.c:111:26: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'
#0 0x7f6776799c2e in reflect ../libfprint/drivers/goodixmoc/goodix_proto.c:111
goodix-fp-linux-dev#1 0x7f677679a0f3 in crc32_final ../libfprint/drivers/goodixmoc/goodix_proto.c:147
goodix-fp-linux-dev#2 0x7f677679a3ee in gx_proto_crc32_calc ../libfprint/drivers/goodixmoc/goodix_proto.c:164
goodix-fp-linux-dev#3 0x7f677679d7aa in gx_proto_init_sensor_config ../libfprint/drivers/goodixmoc/goodix_proto.c:464
goodix-fp-linux-dev#4 0x7f6776797b40 in gx_fp_init ../libfprint/drivers/goodixmoc/goodix.c:1415
goodix-fp-linux-dev#5 0x7f67766cc56e in fp_device_open ../libfprint/fp-device.c:866
goodix-fp-linux-dev#6 0x7f67766d2fd4 in fp_device_open_sync ../libfprint/fp-device.c:1872
sarovin
pushed a commit
to sarovin/libfprint
that referenced
this pull request
Mar 23, 2025
../libfprint/drivers/goodixmoc/goodix_proto.c:214:5: runtime error: null pointer passed as argument 2, which is declared to never be null
#0 0x7f378839c3e5 in gx_proto_build_package ../libfprint/drivers/goodixmoc/goodix_proto.c:214
goodix-fp-linux-dev#1 0x7f378838fd9e in alloc_cmd_transfer ../libfprint/drivers/goodixmoc/goodix.c:309
goodix-fp-linux-dev#2 0x7f378838ffe4 in goodix_sensor_cmd ../libfprint/drivers/goodixmoc/goodix.c:336
goodix-fp-linux-dev#3 0x7f378839a778 in gx_fp_template_delete_all ../libfprint/drivers/goodixmoc/goodix.c:1602
goodix-fp-linux-dev#4 0x7f37882d3d59 in fp_device_clear_storage ../libfprint/fp-device.c:1820
goodix-fp-linux-dev#5 0x7f37882d50af in fp_device_clear_storage_sync ../libfprint/fp-device.c:2132
sarovin
pushed a commit
to sarovin/libfprint
that referenced
this pull request
Mar 23, 2025
This is was leading to a potential error due to misaligned memory:
../libfprint/drivers/goodixmoc/goodix.c:167:20: runtime error: load of
misaligned address 0x00001165c989 for type 'uint32_t', which requires 4 byte
alignment
0x00001165c989: note: pointer points here
00 00 00 00 0a ac b3 09 00 00 00 00 00 00 55 53 42 00 00 00 00 00 56 42 53 00 00 00 00 00 30 30
^
#0 0x7ff3ba98d190 in fp_cmd_receive_cb ../libfprint/drivers/goodixmoc/goodix.c:167
goodix-fp-linux-dev#1 0x7ff3baa3b235 in transfer_finish_cb ../libfprint/fpi-usb-transfer.c:352
goodix-fp-linux-dev#2 0x7ff3c18ca862 in g_task_return_now ../../glib/gio/gtask.c:1363
goodix-fp-linux-dev#3 0x7ff3c18ca89c in complete_in_idle_cb ../../glib/gio/gtask.c:1377
goodix-fp-linux-dev#4 0x7ff3c228470b in g_main_dispatch ../../glib/glib/gmain.c:3373
goodix-fp-linux-dev#5 0x7ff3c22868de in g_main_context_dispatch_unlocked ../../glib/glib/gmain.c:4224
goodix-fp-linux-dev#6 0x7ff3c22868de in g_main_context_iterate_unlocked ../../glib/glib/gmain.c:4289
goodix-fp-linux-dev#7 0x7ff3c2286fef in g_main_context_iteration ../../glib/glib/gmain.c:4354
goodix-fp-linux-dev#8 0x7ff3ba8d2fe5 in fp_device_open_sync ../libfprint/fp-device.c:1874
sarovin
pushed a commit
to sarovin/libfprint
that referenced
this pull request
Mar 23, 2025
We had some read issues, so let's just use the safer reader that
makes things cleaner too
../libfprint/drivers/goodixmoc/goodix_proto.c:418:42: runtime error:
load of misaligned address 0x0000115ced29 for type 'uint16_t', which
requires 2 byte alignment
0x0000115ced29: note: pointer points here
00 c0 3f 00 21 64 1c 00 00 00 00 64 00 43 01 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
^
#0 0x7f974ff9e868 in gx_proto_parse_body ../libfprint/drivers/goodixmoc/goodix_proto.c:418
goodix-fp-linux-dev#1 0x7f974ff8ec79 in fp_cmd_receive_cb ../libfprint/drivers/goodixmoc/goodix.c:185
goodix-fp-linux-dev#2 0x7f975003ca0c in transfer_finish_cb ../libfprint/fpi-usb-transfer.c:352
goodix-fp-linux-dev#3 0x7f9756e57862 in g_task_return_now ../../glib/gio/gtask.c:1363
goodix-fp-linux-dev#4 0x7f9756e5789c in complete_in_idle_cb ../../glib/gio/gtask.c:1377
goodix-fp-linux-dev#5 0x7f97577f070b in g_main_dispatch ../../glib/glib/gmain.c:3373
goodix-fp-linux-dev#6 0x7f97577f28de in g_main_context_dispatch_unlocked ../../glib/glib/gmain.c:4224
goodix-fp-linux-dev#7 0x7f97577f28de in g_main_context_iterate_unlocked ../../glib/glib/gmain.c:4289
goodix-fp-linux-dev#8 0x7f97577f2fef in g_main_context_iteration ../../glib/glib/gmain.c:4354
goodix-fp-linux-dev#9 0x7f974fed4656 in fp_device_verify_sync ../libfprint/fp-device.c:1976
sarovin
pushed a commit
to sarovin/libfprint
that referenced
this pull request
Mar 23, 2025
../libfprint/drivers/uru4000.c:743:35: runtime error: left shift of 138 by 24
places cannot be represented in type 'int'
#0 0x7fa3e696e06d in imaging_run_state ../libfprint/drivers/uru4000.c:743
goodix-fp-linux-dev#1 0x7fa3e6a366f6 in __ssm_call_handler ../libfprint/fpi-ssm.c:254
goodix-fp-linux-dev#2 0x7fa3e6a38cc8 in fpi_ssm_next_state ../libfprint/fpi-ssm.c:465
goodix-fp-linux-dev#3 0x7fa3e696bd07 in sm_read_reg_cb ../libfprint/drivers/uru4000.c:515
goodix-fp-linux-dev#4 0x7fa3e6a3db74 in transfer_finish_cb ../libfprint/fpi-usb-transfer.c:352
goodix-fp-linux-dev#5 0x7fa3ed9b9862 in g_task_return_now ../../glib/gio/gtask.c:1363
goodix-fp-linux-dev#6 0x7fa3ed9b989c in complete_in_idle_cb ../../glib/gio/gtask.c:1377
goodix-fp-linux-dev#7 0x7fa3ede4a70b in g_main_dispatch ../../glib/glib/gmain.c:3373
goodix-fp-linux-dev#8 0x7fa3ede4c8de in g_main_context_dispatch_unlocked ../../glib/glib/gmain.c:4224
goodix-fp-linux-dev#9 0x7fa3ede4c8de in g_main_context_iterate_unlocked ../../glib/glib/gmain.c:4289
goodix-fp-linux-dev#10 0x7fa3ede4cfef in g_main_context_iteration ../../glib/glib/gmain.c:4354
goodix-fp-linux-dev#11 0x7fa3e68d4a1b in fp_device_capture_sync ../libfprint/fp-device.c:2048
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.