Skip to content

skip issues of file "C" #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

skip issues of file "C" #63

wants to merge 1 commit into from

Conversation

tgulacsi
Copy link

@tgulacsi tgulacsi commented Jun 3, 2018

Solves

WARN[0005] running error: can\'t print 99 issues: can\'t read file C for printing issued line: open C: no such file or directory

errors of checking projects using cgo.

You can check it on gopkg.in/goracle.v2

Solves

    WARN[0005] running error: can\'t print 99 issues: can\'t read file C for printing issued line: open C: no such file or directory

errors of checking projects using cgo.
@jirfag
Copy link
Contributor

jirfag commented Jun 3, 2018

thank you for the contribution!
But this fix should be done in a next way:

  1. checking filename in nolint processor: now it's in text printer, but there are also json and tab printers.
  2. adding a test for this case similar to existing tests for nolint processor

Copy link
Contributor

@jirfag jirfag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs changes

@jirfag
Copy link
Contributor

jirfag commented Jun 6, 2018

fixed in #70

@jirfag jirfag closed this Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants