Skip to content

dev: replace fmt.Errorf by errors.New #4647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2024
Merged

dev: replace fmt.Errorf by errors.New #4647

merged 2 commits into from
Apr 16, 2024

Conversation

alexandear
Copy link
Member

@alexandear alexandear commented Apr 15, 2024 •
edited by ldez
Loading

replace fmt.Errorf by errors.New when possible

@alexandear alexandear added the topic: cleanup Related to code, process, or doc cleanup label Apr 15, 2024
@ldez
Copy link
Member

ldez commented Apr 15, 2024 •
edited
Loading

We will not enable perfsprint because readability is better than micro-potential optimization.

Clear is better than clever.
https://go-proverbs.github.io/

@ldez ldez changed the title dev: enable perfsprint linter dev: replace fmt.Errorf by errors.New Apr 15, 2024
@ldez ldez added this to the next milestone Apr 15, 2024
@ldez ldez self-requested a review April 15, 2024 18:12
alexandear
alexandear commented Apr 15, 2024
View reviewed changes
@ldez ldez merged commit 9ccb20d into golangci:master Apr 16, 2024
@alexandear alexandear deleted the feat/enable-perfsprint branch April 16, 2024 14:49
@ldez ldez modified the milestones: next, v1.58 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Milestone
v1.58
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @ldez