-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
build(deps): bump go-simpler.org/sloglint from 0.5.1 to 0.6.0 #4645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not modify:
.golangci.reference.ymljsonschema/golangci.jsonschema.json
Also context-only should be removed from:
.golangci.next.reference.ymljsonschema/golangci.next.jsonschema.json
I think context is good, at least less weird than no-contextless (IMHO it's not easier to understand)
The values can be improved, for example:
all->alwaysscope->existing
If it is removed from the next version schema, won't it become illegal to use in the config? Thus, breaking backward compatibility with existing configs. |
"illegal" no 😄 The JSON schema validation is only called explicitly, but the deprecation warning will always display, so everything will still work as expected. |
ldez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In continuation to #4512
Not sure about the new name,
contextdoes not seem descriptive to me. Maybe something likeno-contextless? Weird, but easier to understand.Please don't merge it yet, I'm going to update the pinned version later.
I've also improved the report message slightly.
go-simpler/sloglint@v0.5.1...v0.6.0