dev: fix variables incorrectly passed to 'go build'

[ashmckenzie]

This PR aims to solve #4368 by ensuring the APP_VERSION and CGO_ENABLED variables are correctly set prior to being used by go build:

Before (from d751398)

$ docker build --quiet -f build/Dockerfile --build-arg VERSION=9.9.9 --build-arg SHORT_COMMIT=abc123 --build-arg DATE=now . -t test/golang-ci-lint && docker run --rm -ti test/golang-ci-lint golangci-lint version
sha256:6749ff93236299ceac1d04987f3384415fa7f081cfc9ea8695412a2a86f30690
golangci-lint has version  built with go1.22.0 from abc123 on now

After (from ashmckenzie/fix-missing-version-in-docker-build)

$ docker build --quiet -f build/Dockerfile --build-arg VERSION=9.9.9 --build-arg SHORT_COMMIT=abc123 --build-arg DATE=now . -t test/golang-ci-lint && docker run --rm -ti test/golang-ci-lint golangci-lint version
sha256:2f2607b9836e56d75b7aca69363aa5329619bcaf8a46d2448957d450645550ce
golangci-lint has version 9.9.9 built with go1.22.0 from abc123 on now

Closes: #4368

[boring-cyborg]

Hey, thank you for opening your first Pull Request !

[CLAassistant]

All committers have signed the CLA.

[ldez]

Hello @ashmckenzie, thank you for the issue and the PR ❤️

I think we will solve this problem by stopping the old approach with a "manual" build, and just integrating the build of the images inside the goreleaser process.
See #4370.

[ashmckenzie]

Hi @ldez, thanks for the quick response!

#4370 looks like a more scalable approach for the future which is great but the diff is quite large in comparison to the two line fix here 🙂

Would you consider merging this PR as a bugfix and #4370 as a feature improvement ?

[ldez]

There is a large diff but it's really easy to review and test it.

I don't close your PR for now, I will see with the other maintainers if they have the time to review my PR.

In all cases, your PR or my PR will be a part of the next bug-fix release.