sloglint: add static-msg option #4213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloglint v0.3.0 was updated in #4183, but missed the new static-msg option. This adds support for that option to golangci-lint.
|
Hey, thank you for opening your first Pull Request ! |
|
|
ldez
changed the title
ldez
added
the
linter: update
Member
|
Hello @mattdowdell, |
Contributor
Author
|
@ldez I left it in draft while I get approval to sign the CLA. Given how innocuous the change is, I'm hoping that won't take long. |
Member
|
@mattdowdell any news? |
Contributor
Author
|
One of my colleagues from legal reached out to check the diff size (28 lines) and if there was any IP within that, but unfortunately no approval as of yet. |
Contributor
Author
|
@ldez CLA signed |
ldez
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sloglint v0.3.0 was updated in #4183, but missed the new static-msg option. This adds support for that option to golangci-lint.