Add goptrcmp linter

.golangci.reference.yml

@@ -2364,6 +2364,7 @@ linters:
     - gomoddirectives
     - gomodguard
     - goprintffuncname
+    - goptrcmp
     - gosec
     - gosimple
     - gosmopolitan
@@ -2484,6 +2485,7 @@ linters:
     - gomoddirectives
     - gomodguard
     - goprintffuncname
+    - goptrcmp
     - gosec
     - gosimple
     - gosmopolitan

go.mod

@@ -115,6 +115,7 @@ require (
 	github.com/ultraware/whitespace v0.1.0
 	github.com/uudashr/gocognit v1.1.2
 	github.com/valyala/quicktemplate v1.7.0
+	github.com/w1ck3dg0ph3r/goptrcmp v0.1.1
 	github.com/xen0n/gosmopolitan v1.2.2
 	github.com/yagipy/maintidx v1.0.0
 	github.com/yeya24/promlinter v0.2.0

pkg/golinters/goptrcmp.go

@@ -0,0 +1,17 @@
+package golinters
+
+import (
+	"github.com/w1ck3dg0ph3r/goptrcmp"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+)
+
+func NewGoPtrCmp() *goanalysis.Linter {
+	return goanalysis.NewLinter(
+		"goptrcmp",
+		"Reports comparison between pointer values",
+		[]*analysis.Analyzer{goptrcmp.Analyzer()},
+		nil,
+	).WithLoadMode(goanalysis.LoadModeTypesInfo)
+}

pkg/lint/lintersdb/manager.go

@@ -538,6 +538,12 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithPresets(linter.PresetStyle).
 			WithURL("https://github.com/jirfag/go-printf-func-name"),
 
+		linter.NewConfig(golinters.NewGoPtrCmp()).
+			WithLoadForGoAnalysis().
+			WithSince("v1.55.3").
+			WithPresets(linter.PresetBugs).
+			WithURL("https://github.com/w1ck3dg0ph3r/goptrcmp"),
+
 		linter.NewConfig(golinters.NewGosec(gosecCfg)).
 			WithSince("v1.0.0").
 			WithLoadForGoAnalysis().

test/testdata/goptrcmp.go

@@ -0,0 +1,48 @@
+//golangcitest:args -Egoptrcmp
+package testdata
+
+import (
+	"fmt"
+)
+
+type Foo struct {
+	String  string
+	Pointer *string
+}
+
+func CmpFoos(a, b *Foo) bool {
+	if a != b { // want "pointer comparison: a != b"
+		return false
+	}
+
+	if a == nil {
+		return false
+	}
+
+	if nil == b {
+		return false
+	}
+
+	if *a != *b {
+		return false
+	}
+
+	if a.String != b.String {
+		return false
+	}
+
+	if a.Pointer != b.Pointer { // want "pointer comparison: a.Pointer != b.Pointer"
+		return false
+	}
+
+	if *a.Pointer != *b.Pointer {
+		return false
+	}
+
+	fmt.Println(a == b) // want "pointer comparison: a == b"
+	fmt.Println(a.String == b.String)
+	fmt.Println(a.Pointer == b.Pointer) // want "pointer comparison: a.Pointer == b.Pointer"
+	fmt.Println(*a.Pointer == *b.Pointer)
+
+	return true
+}