tagliatelle: extraInitialisms case issue

[erane-opti]

Welcome

• Yes, I'm using a binary release within 2 latest releases. Only such installations are supported.
• Yes, I've searched similar issues on GitHub and didn't find any.
• Yes, I've read the typecheck section of the FAQ.
• Yes, I've tried with the standalone linter if available (e.g., gocritic, go vet, etc.).
• I agree to follow this project's Code of Conduct

How did you install golangci-lint?

Official binary

Description of the problem

Configuring tagliatelle.extended-rules initialisms overrides has 2 issues:

1. Mostly docs issue but TagliatelleExtendedRule struct doesn't have mapstructure tags on both ExtraInitialisms and InitialismOverrides making the docs mismatching the actual keys needed in config.yaml . This hold both to v1 and v2:

          # Adds 'AMQP', 'DB', 'GID', 'RTP', 'SIP', 'TS' to initialisms,
          # and removes 'LHS', 'RHS' from initialisms.
          # Default: false
          extra-initialisms: true
          # Defines initialism additions and overrides.
          # Default: empty
          initialism-overrides:
            DB: true # add a new initialism
            LHS: false # disable a default initialism.
            # ...

2. The main issue: viper's loader converts all map keys to lower case [Loading a YAML file makes all keys lowercase, but YAML keys are case sensitive. spf13/viper#260] so when loading InitialismOverrides all keys are lowered. OTOH, tagliatelle uses github.com/ettle/strcase which expects initialisms map keys to be all uppercase: convert.go

I think toExtendedRules should probably fix this (or maybe @ldez think its tagliatelle job?)

I don't see any obvious quick workaround without changing some code

Version of golangci-lint

$ golangci-lint --version
golangci-lint --version
golangci-lint has version 1.64.8 built with go1.24.1 from 8b37f141 on 2025-03-17T20:41:53Z

Configuration

run:
  allow-parallel-runners: true

output:
  formats: colored-line-number

linters-settings:
  tagliatelle:
    case:
      rules:
        json: goCamel
      extended-rules:
        json:
          case: goCamel
          ExtraInitialisms: true
          InitialismOverrides:
            'AWS': true
linters:
  enable:
    - tagliatelle

Go environment

$ go version && go env
go version go1.24.4 linux/amd64
AR='ar'
CC='gcc'
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_ENABLED='1'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
CXX='g++'
GCCGO='gccgo'
GO111MODULE='on'
GOAMD64='v1'
GOARCH='amd64'
GOAUTH='netrc'
GOBIN=''
GOCACHE='<my user's cache folder>'
GOCACHEPROG=''
GODEBUG=''
GOENV='<my user's .config/go/env''
GOEXE=''
GOEXPERIMENT=''
GOFIPS140='off'
GOFLAGS=''
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build1996663955=/tmp/go-build -gno-record-gcc-switches'
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMOD='<this example path>''
GOMODCACHE='<my user's go/pkg/mod folder> '
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='<my user's go folder> '
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTELEMETRY='local'
GOTELEMETRYDIR='<my user's  telemetry dir>'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.24.4'
GOWORK=''
PKG_CONFIG='pkg-config'

Verbose output of running

$ golangci-lint cache clean
$ golangci-lint run -v
tagfail/tag.go:5:23: json(goCamel): got 'thisIdError' want 'thisIDError' (tagliatelle)
        ThisIDError   string `json:"thisIdError"`
                             ^
tagfail/tag.go:6:23: json(goCamel): got 'thisHttp' want 'thisHTTP' (tagliatelle)
        ThisHttpError string `json:"thisHttp"`
                             ^

A minimal reproducible example or link to a public repository

package tagfail

type Example struct {
	SomeAWSKey    string `json:"someAwsKey"`
	ThisIDError   string `json:"thisIdError"`
	ThisHttpError string `json:"thisHttp"`
}

Validation

• Yes, I've included all information above (version, config, etc.).

Supporter

• I am a sponsor/backer through GitHub or OpenCollective

[boring-cyborg]

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

[ldez]

duplicate of #3280

[ldez]

This is a problem with Viper (cf my previous comment and your description), but I think your idea is right: we can force the uppercase.
As this is a bug with Viper, IMHO, this is not a tagliatelle problem but a golangci-lint problem.

I will open a PR to fix that.

[erane-opti]

@ldez 10x, I hope it can be cherry-picked to v1 as well (we aren't ready to migrate yet)

[ldez]

v1 is no longer maintained since v2.

Go1.25 will happen soon, so I recommend updating to v2 before it.

The command golangci-lint migrate is here to help you.

• https://golangci-lint.run/product/migration-guide/
• 🪩 It's time to create a v2 🚀 #5300
• https://ldez.github.io/blog/2025/03/23/golangci-lint-v2/

[erane-opti]

yeah the main issues are us having some "unique" folders (not all of them) and using //nolint:typecheck to bypass them being loaded, together with IDEA Goland go-linter plugin which doesn't like that setup, I was planning to wait for the Goland 2025.2 and hope it will work then, but this fix might force us to find a more creative solution

[ldez]

//nolint:typecheck doesn't work.

• https://golangci-lint.run/welcome/faq/#why-do-you-have-typecheck-errors
• https://golangci-lint.run/welcome/faq/#why-is-it-not-possible-to-skipignore-typecheck-errors

[ldez]

Do you have a concrete example of a "unique" folder?

Do those folders contain several main functions?
Do those folders contain files that don't compile?

[erane-opti]

mainly multiple main functions , i did try to put each in its own package, but something wasn't working with IDEA's plugin (i'll revisit it tomorrow)

[ldez]

Yes, the solution is to use multiple packages: one per main function.

Don't hesitate to share your journey; it can help other users.